From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84EEAC48BD4 for ; Tue, 25 Jun 2019 09:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57D0F208CA for ; Tue, 25 Jun 2019 09:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729730AbfFYJIZ convert rfc822-to-8bit (ORCPT ); Tue, 25 Jun 2019 05:08:25 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:44770 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729164AbfFYJIY (ORCPT ); Tue, 25 Jun 2019 05:08:24 -0400 Received: by mail-ed1-f68.google.com with SMTP id k8so25999540edr.11 for ; Tue, 25 Jun 2019 02:08:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=p826yz7xrmb/dtygzOjwnRJYVkCeMNGjVrwTiRVJZzU=; b=MTRC7diTIfjMjsBpxyai059uL+WWmc9TINLNavwDxzTjQQHENAYxE/4HQTyEtsMiii CJ7UImI3VBrmQs5jcV9ZGRQdPPgQDbfA02q5iKkTN184HJGpZ6LW2XBVn4tTkZcaKZaA 1F96bEuTSeii3S2YVHFQ7vEXnS1XtoF+LwSVsrQ30X+B9POvfbasYQY+Zwp1Ysng+dZG Bu4R2Ht0eprUa9cBMfShG9lZRHsqjSpSUahl5Hfare+akWqclKd5V/hasNeQmH8a0MtY AVFleG1nGqAHlY54OPDKheuOyRmIMWvd6Je9lwItlKq2N+rV7YuMR9nX+Ja5YSHQcMDe AOrg== X-Gm-Message-State: APjAAAWlumD9abLkf6/UnPMJ3q11mxIbUcAP/TNGs7JJC4ERAjHvuTcA yyhZX7DNuIAqc1eSC9kfp2zS6Q== X-Google-Smtp-Source: APXvYqyCdZoQKzpVGmDEkqwdoquR6Zo4COTDT/sVVSdAEBy6ZA14go0xVZPkihAf1uP+MoeTw/lBAA== X-Received: by 2002:a50:fb86:: with SMTP id e6mr43394900edq.203.1561453703247; Tue, 25 Jun 2019 02:08:23 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id g16sm4598529edc.76.2019.06.25.02.08.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 25 Jun 2019 02:08:22 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 19CAB1800B0; Tue, 25 Jun 2019 11:08:22 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: "Daniel T. Lee" , Daniel Borkmann , Alexei Starovoitov Cc: bpf@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent In-Reply-To: <20190625005536.2516-1-danieltimlee@gmail.com> References: <20190625005536.2516-1-danieltimlee@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 25 Jun 2019 11:08:22 +0200 Message-ID: <878stqdoc9.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org "Daniel T. Lee" writes: > Currently, each xdp samples are inconsistent in the use. > Most of the samples fetch the interface with it's name. > (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) > > But some of the xdp samples are fetching the interface with > ifindex by command argument. > > This commit enables xdp samples to fetch interface with it's name > without changing the original index interface fetching. > ( fetching in the same way as xdp_sample_pkts_user.c does.) > > Signed-off-by: Daniel T. Lee > --- > Changes in v2: > - added xdp_redirect_user.c, xdp_redirect_map_user.c Great, thanks! Acked-by: Toke Høiland-Jørgensen