From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 456DF2586EA for ; Fri, 11 Apr 2025 17:54:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744394093; cv=none; b=mjVB6/QM/3WrlX44vY94F0bnlrKdRYnEcMIGG0C3Udheo0JfUqMibU/B0bCPwrnoAedtuPpZnzFK58+yyJEAjZmkak8Lwvojq/E8x4Ie7ImseFs10kX4NinIkn3A49Sbiv6LvXbFZKFcEATgvKFF57GH7fHjHTdBXe/Q+h2D0UA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744394093; c=relaxed/simple; bh=ucba/TyRjphp5QB5NmFsNbDWb/WFdcnndSRrwoEMpJA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=StrHfNj5RWvvGO+8/JcmL+gxT+lfTeTL51kc+dLikOJzWj9cEvdwtIYmXTVxWaydRFlMr6/O6EkPelhlq4LfvD/Zlw2IHfLiAop8eY3a7eP05QFevsRVO/mtDurUDxLnTthyw8M7uYxyvQ0ScTrbgQbo1S9dEU8gNWyYmQ5TA70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=XIe8zYUP; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="XIe8zYUP" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ac2bdea5a38so391314166b.0 for ; Fri, 11 Apr 2025 10:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1744394089; x=1744998889; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uZElioqvOJMRGLrrbRjtOKF/8Aggf8tT1T8UOQr1p6A=; b=XIe8zYUPdcuX4Vl9xiQHoFR6q7oqLvwv7yFoLGQk/648ktFbwV4erdH8vnG4UNV7W/ 4gqjXnDyTNzYf7Ro1TApfEldZpVvs2o4d5tZRSfNwQZZGsfeSL3BlxAtULHN1M7aKQgi XXFwNGzogrlL+z+9HIxZiUIR/mQLyNwX3Anda/UWqZiSq1c5axT8sqvWU3EutLven15V Jj8OWgsfRDeufCHi0tqPqmDdZifzNWFXR2NNmESArXmCMW25jJJlFQucVAgGt52nsfLc G1lnt9LX1ARITZ1pqid+Mb/R8j46HIDBhKJkvRaFHjCILoxzPbQrs4h+2d/2HnkwD9hH P7PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744394089; x=1744998889; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uZElioqvOJMRGLrrbRjtOKF/8Aggf8tT1T8UOQr1p6A=; b=d2AAKqukB8ac9dl2/pwM7Yq7mdhgOqGvQU1YF09MG5bSvkEUCCTsD9Uh6umFpAjLsg fB2+IL3xHvqKsZmKRfJ/tC//bU7xjFZpD5vvWkjcT8uN8nV1+Jh7EYzhtxUSQjcauWep XEuUo2tpLM0RbxVCdgAHzV8opXbyW77bsBZazrKqLgmvTevAvbpTNEGCRN1GjSAD6az5 BSlk6DSfsKC1Dy5Aro98iMq39dnVQislLLC67+oeztjVRFCkzdLiBuurNKQf5rFD4fI1 tiq+mg2/lPt03j6z592/Ql+//AVXyxZpg2B0sMfRcEdzec9JBvi3Kv5A5ywQiHTxakU5 A/bQ== X-Forwarded-Encrypted: i=1; AJvYcCXS6t7pwQmDI7WpRZmed6ThXkWlAvnC5N3hlaohaXOxOeOBIIZcKgjcMnY441jAhxc9S6U=@vger.kernel.org X-Gm-Message-State: AOJu0YwF3uRh63LqzylqeHPYIVOaU6TisUuwGtN/kiDlDyIHA3Nk8jt/ Cqjsj0L6f0CiagdDPjMDj5XNesBORzabeuWrCMVTR/udKbr55QDUyq2R/Qj0/3M= X-Gm-Gg: ASbGncv6itRxTWDcyhH5dBwrbMLh+uN41hSz63j4MWNobVuGC2xsVkw3ffS4I4B5EQR XccpMiruZmnBzGmRA98W2y8XDgCM5dluYrB3IvWJ5qjrhH0qUIQJi6pi+tCC9RYCMo6rg0GHnIF HynxFp265JQ7LZPc4awxMhbNgfq3szqMjq16GaPUaRxmx64wA1//yhWXrWsop0S0rnRjjbkvaXa ypKbyY41X0RLyhBCgZUO16M4/eXRDctDdxDvTdXuxG7YsNSUmBP61HrP9lmY6KBfyYJkvhN3HAU LXMvtbLBCVToAwzkIpO2pANWXLGUjaZz X-Google-Smtp-Source: AGHT+IHlsd1OjqlMWlAQPwwAuOKfCl8uk/pGPlrihEPFE8d9StcXjSTkGzgHNBrELNxLTW7C3iUInw== X-Received: by 2002:a17:907:6d0b:b0:ac2:cae8:e153 with SMTP id a640c23a62f3a-acad3445f7emr328570666b.4.1744394089440; Fri, 11 Apr 2025 10:54:49 -0700 (PDT) Received: from cloudflare.com ([2a09:bac5:506a:2387::38a:3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ce70ebsm479714666b.178.2025.04.11.10.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 10:54:48 -0700 (PDT) From: Jakub Sitnicki To: Jiayuan Chen , Michal Luczaj Cc: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Jonathan Corbet , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH bpf-next v2 5/9] selftests/bpf: Add selftest for sockmap/hashmap redirection In-Reply-To: (Jiayuan Chen's message of "Fri, 11 Apr 2025 21:09:53 +0800") References: <20250411-selftests-sockmap-redir-v2-0-5f9b018d6704@rbox.co> <20250411-selftests-sockmap-redir-v2-5-5f9b018d6704@rbox.co> Date: Fri, 11 Apr 2025 19:54:47 +0200 Message-ID: <87a58mh9co.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Apr 11, 2025 at 09:09 PM +08, Jiayuan Chen wrote: > On Fri, Apr 11, 2025 at 01:32:41PM +0200, Michal Luczaj wrote: >> Test redirection logic. All supported and unsupported redirect combinations >> are tested for success and failure respectively. >> >> BPF_MAP_TYPE_SOCKMAP >> BPF_MAP_TYPE_SOCKHASH >> x >> sk_msg-to-egress >> sk_msg-to-ingress >> sk_skb-to-egress >> sk_skb-to-ingress > > Could we also add test cases for SK_PASS (and even SK_DROP)? > Previously, we encountered deadlocks and incorrect sequence issues when > the program returned SK_PASS, so explicit testing for these cases would > be helpful. > > If implemented, this test would fully exercise all code paths and > demonstrate a complete example that covers every aspect of > sockmap's packet steering and connection management capabilities. This could easily be a follow up in my mind. [...]