From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 151DB85658 for ; Tue, 5 Mar 2024 15:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709653626; cv=none; b=H0UiAujEqdrDM57BqL2wYNSW8Xe5K27MYZ7zCYE+KfrL7L8qcw2xL4N/hZXA6i96iG3V0qouLX1BEo97wEIHkwMuTbeWh32oSubIZciD2+ptUFxtEE4pmsMo54r/isFUpY606qXl7DaN0P/M2qSFP7tDsToAzWG2XUY9PJ4jFg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709653626; c=relaxed/simple; bh=FEXuh7aPZCx/CSz8uFmyZcg8wFbn5WBkJuKn4llrKHA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=evvVI05kVOhVctcrIvJbvJ5T/bFJVyRTf59512etl4UGHwrQ4hkqq2bvbvM9pqzCBYUAUGhOb287UtfcU1PFOIJ55EHAYjktmPmy7Hwcxyc9nL+TrNXQ6eEawHKCRRMpmygJPeRbQ0kQLTsuz+4hG0YVqXKT/Ab3OzUU0qHDR/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Mn93Kep9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mn93Kep9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709653624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yTHTZFSSmBz46FaV6w2gu++Ghv9Cs7q4lZmhZ9Kca6Y=; b=Mn93Kep9mtREBDWmlsoEOqw4INj2+mQnFi67ajRqVxvMSQkf12Pb6gug1BOPtlV6fTYB5t wvAekJiS/NLdFSTn2OCj3luz+gMtWwwkkINVic21kkZibUMHl7EoxrTFbHLJyHxBH/AOmc Lsa5CpufXQhrflkSiDLwaTIj+A8St0w= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-Vx_wmCwdMqK3zwCVUBpbWg-1; Tue, 05 Mar 2024 10:47:02 -0500 X-MC-Unique: Vx_wmCwdMqK3zwCVUBpbWg-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-566fbaeb401so2408393a12.1 for ; Tue, 05 Mar 2024 07:47:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709653622; x=1710258422; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yTHTZFSSmBz46FaV6w2gu++Ghv9Cs7q4lZmhZ9Kca6Y=; b=B/FQ58LWqsdrbI4QTqngiogD7rpggy0d/T0EqeuV7uq3rQ8o/622+WI4iMsMUab/tU 6NpOC87lLsu8LYIUeASTm5Y4hGvhgcqfvZbmbzm3Unf8bipkAc00qwo9/cAIl5AAGsrr Bl1RI48tiHD02bT45dbO8nOn84NTZjeRby3rXOVW+P6rdQHa/67NkV6er5sbYVuqPDNa mBoBRdVOakV+kXydouEN1VBXZ+YrB1+H2QcrBt/rMPJpNz43nqJFzf/F/j5z4ZuiRZaU MjM65LRbRZ579EJu3wG3M3UzbYxQ39QVnMRfEunE27YboVDbmX8sqma3rNhzoa8We1oc WjoQ== X-Forwarded-Encrypted: i=1; AJvYcCXH1rhDe+92HCh1Uyo7xjKegDAApbDNZ18d1up3iCqhnwbiHU7NFT5Ivega9B+2BO/mEJaY7j4wVhDpdtEvLcowg0mv X-Gm-Message-State: AOJu0Yx7iw1K1/q7YpIKHRq2JomoFhfjPgU+4KW1Pmwj33a9vx6is04J SQYNIN/KfP39aXlIt8j76uRDiUaURM7l+aXWrzpwRM9+H5vX88mFme+qTI1lMNpykYzwBJhHEW7 M6Vzfks+pdLE5LJJ+cSp/7hyxN7V+mheBIsJ8yt7f8vNG0Uu1iQ== X-Received: by 2002:a17:906:7ca:b0:a45:aacb:349b with SMTP id m10-20020a17090607ca00b00a45aacb349bmr1338475ejc.16.1709653621779; Tue, 05 Mar 2024 07:47:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQNmbVLw++QhhSEUPNbxq+9CI0G7fV/SEn4yFqU0DB9KZsF5i2KrFJayRdLs8oJVHcwM7qYg== X-Received: by 2002:a17:906:7ca:b0:a45:aacb:349b with SMTP id m10-20020a17090607ca00b00a45aacb349bmr1338468ejc.16.1709653621606; Tue, 05 Mar 2024 07:47:01 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id lm7-20020a170906980700b00a449fdfe27bsm4838566ejb.170.2024.03.05.07.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 07:47:01 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D2917112EF0A; Tue, 5 Mar 2024 16:47:00 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Daniel Borkmann , bpf@vger.kernel.org Cc: netdev@vger.kernel.org, Daniel Borkmann Subject: Re: [PATCH bpf 2/2] selftests/bpf: Fix up xdp bonding test wrt feature flags In-Reply-To: <20240305090829.17131-2-daniel@iogearbox.net> References: <20240305090829.17131-1-daniel@iogearbox.net> <20240305090829.17131-2-daniel@iogearbox.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 05 Mar 2024 16:47:00 +0100 Message-ID: <87a5ncd6kr.fsf@toke.dk> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Daniel Borkmann writes: > Adjust the XDP feature flags for the bond device when no bond slave > devices are attached. After 9b0ed890ac2a ("bonding: do not report > NETDEV_XDP_ACT_XSK_ZEROCOPY"), the empty bond device must report 0 > as flags instead of NETDEV_XDP_ACT_MASK. > > # ./vmtest.sh -- ./test_progs -t xdp_bond > [...] > [ 3.983311] bond1 (unregistering): (slave veth1_1): Releasing backup= interface > [ 3.995434] bond1 (unregistering): Released all slaves > [ 4.022311] bond2: (slave veth2_1): Releasing backup interface > #507/1 xdp_bonding/xdp_bonding_attach:OK > #507/2 xdp_bonding/xdp_bonding_nested:OK > #507/3 xdp_bonding/xdp_bonding_features:OK > #507/4 xdp_bonding/xdp_bonding_roundrobin:OK > #507/5 xdp_bonding/xdp_bonding_activebackup:OK > #507/6 xdp_bonding/xdp_bonding_xor_layer2:OK > #507/7 xdp_bonding/xdp_bonding_xor_layer23:OK > #507/8 xdp_bonding/xdp_bonding_xor_layer34:OK > #507/9 xdp_bonding/xdp_bonding_redirect_multi:OK > #507 xdp_bonding:OK > Summary: 1/9 PASSED, 0 SKIPPED, 0 FAILED > [ 4.185255] bond2 (unregistering): Released all slaves > [...] > > Fixes: 9b0ed890ac2a ("bonding: do not report NETDEV_XDP_ACT_XSK_ZEROCOPY") > Signed-off-by: Daniel Borkmann Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen