From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 896D1171AD for ; Mon, 8 May 2023 11:35:58 +0000 (UTC) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0118B3D23E for ; Mon, 8 May 2023 04:35:39 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-50bcb229adaso8400296a12.2 for ; Mon, 08 May 2023 04:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; t=1683545698; x=1686137698; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=wi1WmwjZU1UDCM2ZKZeFH8D7vn1lt5dmnqHCt6P//eQ=; b=LdJX/rsi2nKGEs1QqTI7dIviRwYApO3zup4qaPlc5iq1sfHtQTCAa2vaKAsjVCe7BK T89MaWSlpfX1fsEshwxjJvocrTJORZalUQAOIc7444X1GExpNgyEr2YJC5rzWX3juwXd wxdPd7jI8g7tsH+qNllynHypI26MeDVD6Ajus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683545698; x=1686137698; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wi1WmwjZU1UDCM2ZKZeFH8D7vn1lt5dmnqHCt6P//eQ=; b=K2nT3rIfLPRoqatE0xB8QMHGpY8vyIk9Y2m8fhnEHVbgspRYRWk+2pNVuYDDVb21YR gEW5NmgpykHtH8HEN71qBoBaWTPpBq5xdj8QfMupiGP6l60ovYUcC8NT3I8zDNxGSWdy GU0yEUGmeDdqx3BeD4RQHSkqBb+Oz+YdSi7bX2o6I/LONdZVxkEby+xkyfWIPkna1zbW RRS5PIsqJEHRPhXHExur73y8Aq/KwtiCb6wOmBZ6/nGaa8MLEJAe0Wfm8Ch4VVxQf3Yi W9zEGXnOsrai6wfvDhgVb+jh0jvWnx7pT3YT4NZ5mc9OjPbK3z0s2dRidylu+nKzTgGu Bz+A== X-Gm-Message-State: AC+VfDzrl78C/fGMzq4xTuD+5LdlVJ2pSEUvSrAKL0zg8bwjfOV1bquI 7UcVeUKCkj+b/rRQkZpJsa27hQ== X-Google-Smtp-Source: ACHHUZ7iRk3h5jQ7vP75k8hsdLNZq7bI3KBsYDB9CygdAmVDAdEEtbMNc+LQqEWNbV2/56u+0332Ew== X-Received: by 2002:a17:907:2689:b0:961:272d:bda5 with SMTP id bn9-20020a170907268900b00961272dbda5mr8169437ejc.49.1683545698476; Mon, 08 May 2023 04:34:58 -0700 (PDT) Received: from cloudflare.com (79.184.132.119.ipv4.supernova.orange.pl. [79.184.132.119]) by smtp.gmail.com with ESMTPSA id gz8-20020a170907a04800b009686a7dc71csm634403ejc.30.2023.05.08.04.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 04:34:58 -0700 (PDT) References: <20230502155159.305437-1-john.fastabend@gmail.com> <20230502155159.305437-14-john.fastabend@gmail.com> User-agent: mu4e 1.6.10; emacs 28.2 From: Jakub Sitnicki To: John Fastabend Cc: daniel@iogearbox.net, lmb@isovalent.com, edumazet@google.com, bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org, andrii@kernel.org, will@isovalent.com Subject: Re: [PATCH bpf v7 13/13] bpf: sockmap, test FIONREAD returns correct bytes in rx buffer with drops Date: Mon, 08 May 2023 13:34:27 +0200 In-reply-to: <20230502155159.305437-14-john.fastabend@gmail.com> Message-ID: <87bkiv3vkv.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, May 02, 2023 at 08:51 AM -07, John Fastabend wrote: > When BPF program drops pkts the sockmap logic 'eats' the packet and > updates copied_seq. In the PASS case where the sk_buff is accepted > we update copied_seq from recvmsg path so we need a new test to > handle the drop case. > > Original patch series broke this resulting in > > test_sockmap_skb_verdict_fionread:PASS:ioctl(FIONREAD) error 0 nsec > test_sockmap_skb_verdict_fionread:FAIL:ioctl(FIONREAD) unexpected ioctl(FIONREAD): actual 1503041772 != expected 256 > #176/17 sockmap_basic/sockmap skb_verdict fionread on drop:FAIL > > After updated patch with fix. > > #176/16 sockmap_basic/sockmap skb_verdict fionread:OK > #176/17 sockmap_basic/sockmap skb_verdict fionread on drop:OK > > Signed-off-by: John Fastabend > --- Reviewed-by: Jakub Sitnicki