From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net
Cc: andrii@kernel.org, kernel-team@fb.com
Subject: Re: [PATCH bpf-next] libbpf: fix memleak in libbpf_netlink_recv()
Date: Thu, 17 Feb 2022 14:05:20 +0100 [thread overview]
Message-ID: <87czjl4p9r.fsf@toke.dk> (raw)
In-Reply-To: <20220217073958.276959-1-andrii@kernel.org>
Andrii Nakryiko <andrii@kernel.org> writes:
> Ensure that libbpf_netlink_recv() frees dynamically allocated buffer in
> all code paths.
>
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
> Fixes: 9c3de619e13e ("libbpf: Use dynamically allocated buffer when receiving netlink messages")
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Oops! I saw there were already 'goto done' labels in that block of code
so assumed it was all fine and didn't look closer. Thank you for the
fix!
-Toke
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2022-02-17 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 7:39 [PATCH bpf-next] libbpf: fix memleak in libbpf_netlink_recv() Andrii Nakryiko
2022-02-17 13:05 ` Toke Høiland-Jørgensen [this message]
2022-02-17 15:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czjl4p9r.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox