From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A36B9C54FCB for ; Fri, 24 Apr 2020 14:01:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8572321473 for ; Fri, 24 Apr 2020 14:01:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dhOhdYS1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726968AbgDXOBF (ORCPT ); Fri, 24 Apr 2020 10:01:05 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:58654 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727872AbgDXOBD (ORCPT ); Fri, 24 Apr 2020 10:01:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587736861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JqV6csMf2d/oC1hVByib6X4BqL6+W9+JGkigoSnBbHM=; b=dhOhdYS1WOM/qwLAkxRbwmgBR8yDYB6EWJWA2BBDhqaj/iG3Rb5YKZBHmZmpg9AlamIUB6 fjgJrk7gGGcu3sTs+rC9mqgNrSlQMVfoX5gWR41ZNGcwNm/7D5WFNA1marUMcNTcvVF6zA 03vkuZyrpB6du7dXACvH5KxjKWiKeMM= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-n214zb2NNY23AJpP5bFFCA-1; Fri, 24 Apr 2020 10:01:00 -0400 X-MC-Unique: n214zb2NNY23AJpP5bFFCA-1 Received: by mail-lf1-f70.google.com with SMTP id l5so3941402lfg.3 for ; Fri, 24 Apr 2020 07:00:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=JqV6csMf2d/oC1hVByib6X4BqL6+W9+JGkigoSnBbHM=; b=M+FgN7xxmMWcbWFSdKH+LpSRJD3OPLEq8BPadrs1fE+mPZ58fF2IBVq5jCY6G4XwGR tgQIr0UGg22YTBwykMyX/KXqFSbrc0k9LNE9qKpY+T2eEWkQfYo/Y+9mn4cC0qP4XQ7D 3WbLjOJfO4cdFE8qZ+FIBuba+VfNTARLaj0+SrEicfGfXxwqhH+tbjvRaTtmXWyWwjrH skDbC7TLinPoDpFiE3ro7XwrYTaaPRc2/jkdGz2tsk+5VPlbBaTzs0wfWNF3h294gtYh UgpyRiGrhSLanxpp2V+nTUuBOjG3XqF5c8ZXS8fDRcQEtSQ2EIg2LgOz27HyyNaUWleY GqCA== X-Gm-Message-State: AGi0PuYTsu36utvYzH7SbHTHQpS9AuhooT7HdpHjERgrkhbKroK7KXLI dR1uublwcAQNqmsYbFq8ALSNJgyxUuIk4TDKIiF1jgI7ZmnOTP0w5Bk9gjGsjWj0KUd5XWEYXnG BDit5XEVWAQV/ X-Received: by 2002:a2e:a311:: with SMTP id l17mr6025762lje.106.1587736858388; Fri, 24 Apr 2020 07:00:58 -0700 (PDT) X-Google-Smtp-Source: APiQypLFMBlsGM2Z2iNZhFhTOd6GpNHHs8QXLXB0sALxjHaaOWp9qIgvpqMi9sWEsNXM2SMOTGecaw== X-Received: by 2002:a2e:a311:: with SMTP id l17mr6025740lje.106.1587736857812; Fri, 24 Apr 2020 07:00:57 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id t81sm4559912lff.52.2020.04.24.07.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2020 07:00:55 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 597571814FF; Fri, 24 Apr 2020 16:00:53 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jesper Dangaard Brouer , sameehj@amazon.com Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, bpf@vger.kernel.org, zorik@amazon.com, akiyano@amazon.com, gtzalik@amazon.com, Daniel Borkmann , Alexei Starovoitov , John Fastabend , Alexander Duyck , Jeff Kirsher , David Ahern , Willem de Bruijn , Ilias Apalodimas , Lorenzo Bianconi , Saeed Mahameed , steffen.klassert@secunet.com Subject: Re: [PATCH net-next 01/33] xdp: add frame size to xdp_buff In-Reply-To: <158757164613.1370371.2655437650342381672.stgit@firesoul> References: <158757160439.1370371.13213378122947426220.stgit@firesoul> <158757164613.1370371.2655437650342381672.stgit@firesoul> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 24 Apr 2020 16:00:53 +0200 Message-ID: <87eesd3rvu.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Jesper Dangaard Brouer writes: > XDP have evolved to support several frame sizes, but xdp_buff was not > updated with this information. The frame size (frame_sz) member of > xdp_buff is introduced to know the real size of the memory the frame is > delivered in. > > When introducing this also make it clear that some tailroom is > reserved/required when creating SKBs using build_skb(). > > It would also have been an option to introduce a pointer to > data_hard_end (with reserved offset). The advantage with frame_sz is > that (like rxq) drivers only need to setup/assign this value once per > NAPI cycle. Due to XDP-generic (and some drivers) it's not possible to > store frame_sz inside xdp_rxq_info, because it's varies per packet as it > can be based/depend on packet length. > > Signed-off-by: Jesper Dangaard Brouer With one possible nit below: Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen > --- > include/net/xdp.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/include/net/xdp.h b/include/net/xdp.h > index 40c6d3398458..1ccf7df98bee 100644 > --- a/include/net/xdp.h > +++ b/include/net/xdp.h > @@ -6,6 +6,8 @@ > #ifndef __LINUX_NET_XDP_H__ > #define __LINUX_NET_XDP_H__ >=20=20 > +#include /* skb_shared_info */ > + > /** > * DOC: XDP RX-queue information > * > @@ -70,8 +72,19 @@ struct xdp_buff { > void *data_hard_start; > unsigned long handle; > struct xdp_rxq_info *rxq; > + u32 frame_sz; /* frame size to deduct data_hard_end/reserved tailroom*/ I think maybe you want to s/deduct/deduce/ here? -Toke