From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
bpf@vger.kernel.org,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Yonghong Song <yonghong.song@linux.dev>,
david.faust@oracle.com, cupertino.miranda@oracle.com
Subject: Re: [RFC bpf-next] bpf: avoid clang-specific push/pop attribute pragmas in bpftool
Date: Mon, 06 May 2024 21:10:14 +0200 [thread overview]
Message-ID: <87h6faiwo9.fsf@oracle.com> (raw)
In-Reply-To: <14531c3db62da3761e0783d12fa67060171ed722.camel@gmail.com> (Eduard Zingerman's message of "Mon, 06 May 2024 11:55:59 -0700")
> On Sat, 2024-05-04 at 23:09 +0200, Jose E. Marchesi wrote:
>
> [...]
>
>> I have sent a tentative patch that adds the `record_attrs_str'
>> configuration parameter to the btf_dump_opts, incorporating a few
>> changes after Eduard's suggestions regarding avoiding double negations
>> and docstrings.
>
> [...]
>
>> I am not familiar with the particular use cases, but generally speaking
>> separating sorting and emission makes sense to me. I would also prefer
>> that to iterators.
>
> Hi Jose,
>
> I've discussed this issue with Andrii today,
> and we decided that we want to proceed with API changes,
> that introduce two functions: one for sorting ids,
> one for printing single type.
>
> I can do this change on Tue or Wed, if that is ok with you.
Sure, thank you.
next prev parent reply other threads:[~2024-05-06 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 11:18 [RFC bpf-next] bpf: avoid clang-specific push/pop attribute pragmas in bpftool Jose E. Marchesi
2024-05-03 20:36 ` Eduard Zingerman
2024-05-03 21:18 ` Eduard Zingerman
2024-05-03 22:14 ` Andrii Nakryiko
2024-05-04 21:09 ` Jose E. Marchesi
2024-05-06 18:55 ` Eduard Zingerman
2024-05-06 19:10 ` Jose E. Marchesi [this message]
2024-05-06 21:35 ` Andrii Nakryiko
2024-05-06 6:26 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6faiwo9.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cupertino.miranda@oracle.com \
--cc=david.faust@oracle.com \
--cc=eddyz87@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox