From: Jakub Sitnicki <jakub@cloudflare.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
bpf@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH bpf-next 2/3] selftests/bpf: Fix endianness issues in sk_lookup/ctx_narrow_access
Date: Thu, 24 Sep 2020 11:24:31 +0200 [thread overview]
Message-ID: <87h7rnttm8.fsf@cloudflare.com> (raw)
In-Reply-To: <20200909232443.3099637-3-iii@linux.ibm.com>
On Thu, Sep 10, 2020 at 01:24 AM CEST, Ilya Leoshkevich wrote:
> This test makes a lot of narrow load checks while assuming little
> endian architecture, and therefore fails on s390.
>
> Fix by introducing LSB and LSW macros and using them to perform narrow
> loads.
>
> Fixes: 0ab5539f8584 ("selftests/bpf: Tests for BPF_SK_LOOKUP attach point")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
Keeping some lines > 80 chars would make it a bit more readable IMO, but
otherwise LGTM. Thank you for fixing it.
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
[...]
next prev parent reply other threads:[~2020-09-24 9:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 23:24 [PATCH bpf-next 0/3] Fix three endianness issues in test_progs Ilya Leoshkevich
2020-09-09 23:24 ` [PATCH bpf-next 1/3] selftests/bpf: Fix endianness issue in test_sockopt_sk Ilya Leoshkevich
2020-09-10 16:49 ` Andrii Nakryiko
2020-09-09 23:24 ` [PATCH bpf-next 2/3] selftests/bpf: Fix endianness issues in sk_lookup/ctx_narrow_access Ilya Leoshkevich
2020-09-10 16:55 ` Andrii Nakryiko
2020-09-23 21:12 ` Ilya Leoshkevich
2020-09-24 7:49 ` Jakub Sitnicki
2020-09-24 9:24 ` Jakub Sitnicki [this message]
2020-09-09 23:24 ` [PATCH bpf-next 3/3] selftests/bpf: Fix endianness issue in sk_assign Ilya Leoshkevich
2020-09-10 16:56 ` Andrii Nakryiko
2020-09-10 16:58 ` [PATCH bpf-next 0/3] Fix three endianness issues in test_progs Andrii Nakryiko
2020-09-10 21:55 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7rnttm8.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).