From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5BE9C2BA83 for ; Sun, 16 Feb 2020 10:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADD7C2086A for ; Sun, 16 Feb 2020 10:34:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AU7zjrKZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726020AbgBPKeE (ORCPT ); Sun, 16 Feb 2020 05:34:04 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33044 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726651AbgBPKeC (ORCPT ); Sun, 16 Feb 2020 05:34:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581849241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AyZPiWK74GL/snEzHEB39Hj1J71bF2CTXG08laECY4o=; b=AU7zjrKZs4CfcI2GTsVjKBtFrvU7obj2JjsNIGApETBD9dHmIYcjzP1F7TPHHm8p6MC5s7 JacBADf+iU3AWju7BiZ/ix7PwRwQEL7pcbxlIgqp5q7bJAyDIjOUh83HLM74j7J5MxRoO6 zBWiCX6fkMh6PJ/S1vz4/N2Ab1NTZTI= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-Gudy9qQlMWGrS396E2-9Nw-1; Sun, 16 Feb 2020 05:33:59 -0500 X-MC-Unique: Gudy9qQlMWGrS396E2-9Nw-1 Received: by mail-lj1-f197.google.com with SMTP id h26so4878459ljj.0 for ; Sun, 16 Feb 2020 02:33:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=AyZPiWK74GL/snEzHEB39Hj1J71bF2CTXG08laECY4o=; b=KQJCCrixDEJAHPmehhQ9vMx//CvB76UJODNyXXlPFQ+brmSPATrI/8nO5RBVuQQmcf JO+/bg4KZrx6Tqs8eyTr73wwtvJ92fbFFm81cWhHz02LG3lXIVf88kDnvEzYADfWFq8w ZIlbck+EPCt/M/taiPsx9hdEULDJBxizL/yZgVha5JA+7RSok/zxS64PkL8IXjCMDoth HqTf1VUT87qqUnYNQXjhhofTqLd97BBzECfixHY8SA8geUSqb5KabNFwNuTNzSw4d5qh iJvDS4gxeWjO8s4eyGAVSAzqY2abeExUrG9ladvpOUuHvvdi54PnqTnXk0DLsaj+b80t MZYw== X-Gm-Message-State: APjAAAWZaVbWouiyO+tEdQYjcrqPUZWwxoU4JCqKvDGreGrnQYDwNs2b ps1JhhcXzXmpowMXNClA7OQfn7un6HfGpZTjOr2lEYZjzHK9II/Jj6rt+aGjcmXAKMQIIBb5rN5 0hyQfKnMq5XYj X-Received: by 2002:ac2:5979:: with SMTP id h25mr5823558lfp.203.1581849237885; Sun, 16 Feb 2020 02:33:57 -0800 (PST) X-Google-Smtp-Source: APXvYqz5CGpNlEjzA8D5rxS5gBw73IyHetdr4xNVSJIqqTnMYikH1e1wBtykq/V+h6jiwZNsqfmBaA== X-Received: by 2002:ac2:5979:: with SMTP id h25mr5823536lfp.203.1581849237634; Sun, 16 Feb 2020 02:33:57 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a12sm6454240ljk.48.2020.02.16.02.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2020 02:33:56 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DED0E180371; Sun, 16 Feb 2020 11:33:55 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Ilias Apalodimas , netdev@vger.kernel.org Cc: jonathan.lemon@gmail.com, lorenzo@kernel.org, Ilias Apalodimas , Thomas Petazzoni , "David S. Miller" , Jassi Brar , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Jesper Dangaard Brouer , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , John Fastabend , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next] net: page_pool: API cleanup and comments In-Reply-To: <20200216094056.8078-1-ilias.apalodimas@linaro.org> References: <20200216094056.8078-1-ilias.apalodimas@linaro.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Sun, 16 Feb 2020 11:33:55 +0100 Message-ID: <87k14mbz3g.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Ilias Apalodimas writes: > Functions starting with __ usually indicate those which are exported, > but should not be called directly. Update some of those declared in the > API and make it more readable. > > page_pool_unmap_page() and page_pool_release_page() were doing > exactly the same thing. Keep the page_pool_release_page() variant > and export it in order to show up on perf logs. > Finally rename __page_pool_put_page() to page_pool_put_page() since we > can now directly call it from drivers and rename the existing > page_pool_put_page() to page_pool_put_full_page() since they do the same > thing but the latter is trying to sync the full DMA area. > > Also update netsec, mvneta and stmmac drivers which use those functions. > > Suggested-by: Jonathan Lemon > Signed-off-by: Ilias Apalodimas Thanks for the house cleaning :) Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen