From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F763C433EF for ; Mon, 25 Apr 2022 16:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243239AbiDYQNm (ORCPT ); Mon, 25 Apr 2022 12:13:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240524AbiDYQNj (ORCPT ); Mon, 25 Apr 2022 12:13:39 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 284B741FAE for ; Mon, 25 Apr 2022 09:10:35 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id v64-20020a1cac43000000b0038cfd1b3a6dso12811503wme.5 for ; Mon, 25 Apr 2022 09:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=3XDMcq+0fpMzep7G5LNuFm+wNoXj+cb40n5L8nOL/yc=; b=O5wOaDXPw/nP6ndZN4jmEw5CfrzTjsBnevTmGRylWAiCmzMrOKqbHB+elG/aZJ77SC pT88De9bCqiDtZhRp9Wo4TBvdrrjLaFpTkwfvEyHuLzqA3JjQ0Egm3UXW+nBlqJcrCtz 4oj14SGVRkMpxlJqOzAOdyur00K27ojtfiU0o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=3XDMcq+0fpMzep7G5LNuFm+wNoXj+cb40n5L8nOL/yc=; b=Z/1IU1rE1xk+CQ/BGIiZ44CxshYPyEKulceKj/eO2Wu4bSaZnfSqGzkNQ+USyQLCDT mcIpNDYr8m6tIeXzoNAjLLtIyfdx2RFr72C6IgBHmO7HNIuSeNMmKJSwaJ4snXImSwKx c4DZM6QwZq6qc8ekT8N/rM0dIYj6PloCLrXIAN8grceUFlXAzAPQv6771p8Pr0Y2RJdK +uAnwSxUSB6l8F3eRmKc7zY3EquqdT6ihkBsn1QqBtKCtJGV1eKU4oI5mx8mg+OHtwpc CfwAKPmSS0FpAbZMplX1N5eAHFWrQBTGWLIEUiUqVSWSyDTQb1lqdCD31vEVp+pQT7iX V7Xw== X-Gm-Message-State: AOAM531u6lf56pBzJn1Opj3cJZKEPMHgYEbOTCidFqXLenAT3R1a2JjH VXEzBsXjCzntBqNmn9dhQXUwFA== X-Google-Smtp-Source: ABdhPJzkndurt2JOSMJgx5YGGSLBJkzh+Q3vlf2zQdGIaAs8/lTEfazHFcSZHore16GW9xcDLQuF0A== X-Received: by 2002:a05:600c:4f08:b0:391:fe3c:40e6 with SMTP id l8-20020a05600c4f0800b00391fe3c40e6mr26484058wmq.34.1650903033615; Mon, 25 Apr 2022 09:10:33 -0700 (PDT) Received: from cloudflare.com (79.184.126.143.ipv4.supernova.orange.pl. [79.184.126.143]) by smtp.gmail.com with ESMTPSA id p125-20020a1c2983000000b0038e5ca446bcsm12064035wmp.5.2022.04.25.09.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 09:10:33 -0700 (PDT) References: <20211201181040.23337-1-alexei.starovoitov@gmail.com> <20211201181040.23337-6-alexei.starovoitov@gmail.com> <87sfq8f0ex.fsf@cloudflare.com> User-agent: mu4e 1.6.10; emacs 27.2 From: Jakub Sitnicki To: Andrii Nakryiko Cc: Alexei Starovoitov , "David S. Miller" , Daniel Borkmann , Andrii Nakryiko , bpf , Kernel Team , kernel-team Subject: Re: [PATCH v5 bpf-next 05/17] bpf: Pass a set of bpf_core_relo-s to prog_load command. Date: Mon, 25 Apr 2022 18:09:16 +0200 In-reply-to: Message-ID: <87levt6t53.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Apr 20, 2022 at 09:50 AM -07, Andrii Nakryiko wrote: > bpf_attr is supposed to be zeroed out with memset(), so that hole > should have zero even before core_relo_cnt was added Thanks for clarifying. Didn't realize this was the contract. Thought it was worth adding to the bpf(2) man page: https://lore.kernel.org/linux-man/20220425160803.114851-1-jakub@cloudflare.com/