From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf v3 2/3] bpf: Fix hashtab overflow check on 32-bit arches
Date: Mon, 11 Mar 2024 11:58:12 +0100 [thread overview]
Message-ID: <87msr5qbln.fsf@toke.dk> (raw)
In-Reply-To: <CAADnVQLjEeDTmyn2+EsgSy_vkUcOGyUeSPpsLg0ytNnDW+YczQ@mail.gmail.com>
Alexei Starovoitov <alexei.starovoitov@gmail.com> writes:
> On Thu, Mar 7, 2024 at 4:03 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>>
>> - err = -E2BIG;
>> - /* prevent zero size kmalloc and check for u32 overflow */
>> - if (htab->n_buckets == 0 ||
>> - htab->n_buckets > U32_MAX / sizeof(struct bucket))
>> + /* prevent zero size kmalloc */
>> + if (htab->n_buckets > U32_MAX / sizeof(struct bucket))
>
> The comment carried over the wrong half of the comment.
> I fixed it up while applying... to bpf-next.
> There probably will be no bpf pr,
> since the merge window is about to start.
Oops, yeah, completely misread that comment; thanks for fixing! :)
-Toke
next prev parent reply other threads:[~2024-03-11 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 12:03 [PATCH bpf v3 0/3] Fix hash bucket overflow checks for 32-bit arches Toke Høiland-Jørgensen
2024-03-07 12:03 ` [PATCH bpf v3 1/3] bpf: Fix DEVMAP_HASH overflow check on " Toke Høiland-Jørgensen
2024-03-07 12:03 ` [PATCH bpf v3 2/3] bpf: Fix hashtab " Toke Høiland-Jørgensen
2024-03-08 4:09 ` Alexei Starovoitov
2024-03-11 10:58 ` Toke Høiland-Jørgensen [this message]
2024-03-07 12:03 ` [PATCH bpf v3 3/3] bpf: Fix stackmap " Toke Høiland-Jørgensen
2024-03-07 15:55 ` Bui Quang Minh
2024-03-07 16:52 ` Toke Høiland-Jørgensen
2024-03-08 4:10 ` [PATCH bpf v3 0/3] Fix hash bucket overflow checks for " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msr5qbln.fsf@toke.dk \
--to=toke@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox