From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7EE5C433B4 for ; Fri, 7 May 2021 08:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A6CB6145D for ; Fri, 7 May 2021 08:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234484AbhEGIUA (ORCPT ); Fri, 7 May 2021 04:20:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236023AbhEGIUA (ORCPT ); Fri, 7 May 2021 04:20:00 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DB4FC061574 for ; Fri, 7 May 2021 01:18:58 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id b21so10466498ljf.11 for ; Fri, 07 May 2021 01:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=MWUVk7yj4646QDn77Qt6hcagY8Hi56LhWTAfIF7pdMg=; b=DbVZ6yH9o0FYTy0CiT+ADnreY6dYlUSWyGcLtWbjKd3sAAUljty/16PHsUoM/pi12a mJKhcbvaKymrnjtvRMMXSuzu1n5LorL4FJIQkfVtDsDzcYqQtzVWn7NnvRHydCJp02Um fSw4gPpR5hxX/GwrFhcYlhl6xT2NpCApEXp/8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=MWUVk7yj4646QDn77Qt6hcagY8Hi56LhWTAfIF7pdMg=; b=mWqA4F0oT/nQiXUD7i9zJR6ERpezT4QOE+TbbTrOBo2izAK+lrti+jjsdJcqTOf7QQ MkDt12H445vIquMpCUxkAGD/crzpJqC8lNfvSDEc1hHHcnaBquFbYhq+cB/0vOgUdj9Y AJxRKwjLxdprk4d0rCdjyHpkP+3G6CckuEK1hXGxoO6Lpj0b3VQqWTpErPn3TFVv00Wn tmKYbMdlglzA0aLCKyU9fHG0wKxAtuNHOEN2J05jXhcG2Wsvpugwym9jWGoxZHCgQwvb Xy7haNfwTLL7Ggfi6ZUIPr8fZtsNg0JjETJkeNK+QR6bO3Z2fn8kzAS4ZfnUXbUoJGih NdhQ== X-Gm-Message-State: AOAM531P+kdsB4mpR9h6p42XoXz0bhW9dYFnq2yIB/fvRQ0F2N8OvKQP XRmm9UotBZ1ZRALknJTCt7zaog== X-Google-Smtp-Source: ABdhPJypd6aRbK0rSSS+jySi5DZGTAj8XBKj+Bp2XKwZBIBwOv4W4kOyj8SEKhV5o/W7k41GbM3zzA== X-Received: by 2002:a2e:581a:: with SMTP id m26mr6768114ljb.493.1620375536887; Fri, 07 May 2021 01:18:56 -0700 (PDT) Received: from cloudflare.com (83.31.64.64.ipv4.supernova.orange.pl. [83.31.64.64]) by smtp.gmail.com with ESMTPSA id n20sm1284526lfq.186.2021.05.07.01.18.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 01:18:56 -0700 (PDT) References: <20210426025001.7899-1-xiyou.wangcong@gmail.com> <20210426025001.7899-5-xiyou.wangcong@gmail.com> User-agent: mu4e 1.1.0; emacs 27.2 From: Jakub Sitnicki To: Cong Wang Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, jiang.wang@bytedance.com, duanxiongchun@bytedance.com, wangdongdong.6@bytedance.com, Cong Wang , John Fastabend , Daniel Borkmann , Lorenz Bauer Subject: Re: [Patch bpf-next v3 04/10] af_unix: set TCP_ESTABLISHED for datagram sockets too In-reply-to: <20210426025001.7899-5-xiyou.wangcong@gmail.com> Date: Fri, 07 May 2021 10:18:54 +0200 Message-ID: <87mtt7ufbl.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Apr 26, 2021 at 04:49 AM CEST, Cong Wang wrote: > From: Cong Wang > > Currently only unix stream socket sets TCP_ESTABLISHED, > datagram socket can set this too when they connect to its > peer socket. At least __ip4_datagram_connect() does the same. > > This will be used by the next patch to determine whether an > AF_UNIX datagram socket can be redirected in sockmap. > > Cc: John Fastabend > Cc: Daniel Borkmann > Cc: Jakub Sitnicki > Cc: Lorenz Bauer > Signed-off-by: Cong Wang > --- > net/unix/af_unix.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c > index 8968ed44a89f..c4afc5fbe137 100644 > --- a/net/unix/af_unix.c > +++ b/net/unix/af_unix.c > @@ -1206,6 +1206,8 @@ static int unix_dgram_connect(struct socket *sock, struct sockaddr *addr, > unix_peer(sk) = other; > unix_state_double_unlock(sk, other); > } > + > + sk->sk_state = other->sk_state = TCP_ESTABLISHED; `other` can be NULL. In such case we're back to UNCONNECTED state. > return 0; > > out_unlock: [...]