From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75CDF245012 for ; Wed, 9 Apr 2025 10:36:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744194979; cv=none; b=O+xC81QOhRpW0d+ojSZs03kp//PKHMmnj6vcPuzMjRDcmA/aFNYK6+IunjdWbIObQtqAOt0j0nOvVXTPlZkvLYL518C4LejqdZXcUlxZolEXHW1OoSmMo2610wt2s2mDhdaQmygtj7b54c/CfdvVsr33kQk6YhGa5CTeN8UDkRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744194979; c=relaxed/simple; bh=i4ww+FDuhBq9K89tHk8yHaDJA0LXhNvp9fAushoG6jQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=efAVh+kLBiFwEu9AIixeG5WHUD/o9oTlf/4wRD6AHYra2P2C9butnMjd2btPPmDdDWtushjmiS9ylByGbLLbdFN+znCGWDv5Kds0UQfOkDtA/iphFLeKuNiXVhR08PX629MQOGte0sJhlLM+EsGDWJVDqg/D2zLiat/WmllLa2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dEynIQql; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dEynIQql" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744194976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+5kKiovjW0ZhkYwq0PKT65H3P9L8h+uzV491ftb4psU=; b=dEynIQql6sA9ab6nLmZxi7ERSqLbCiMSlmcODiFU0ZvJ7ZrikmTt1edzIX01Fo8c24G5GB 7nGeOVaQMb8hwlMjpzkkWPFLZXB8Al5PNsQ++xjYyeWC1EkED3hfxCPFHSWeo8dYSPA0AC q5nf32BW67JWarMoZtXV87hKJOhqYkQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-XWremiNFN62lv0qiy4Vnsg-1; Wed, 09 Apr 2025 06:36:15 -0400 X-MC-Unique: XWremiNFN62lv0qiy4Vnsg-1 X-Mimecast-MFC-AGG-ID: XWremiNFN62lv0qiy4Vnsg_1744194974 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-ac710ace217so504628766b.1 for ; Wed, 09 Apr 2025 03:36:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744194974; x=1744799774; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+5kKiovjW0ZhkYwq0PKT65H3P9L8h+uzV491ftb4psU=; b=JcGaEyFLuIgL098VOZzmnmv6ZKsciWR1RWKnnkHrU+ul0juqWm4u0WSDg2QRCPqqQx yt3KZ/nKfZTiKz5jf7CTSp0Tt1+vaOpjc4P/9lvWg6cxqOAFix8Qayv1I+GkAqM55h/4 t9kRwNjSNCOsE04oK8p4GSJ3Etvk8Wfit91kslEKyPgalkZH3mtRxN4NASv+QMPegysU ixnOFI/iF+AVYqppCaA0Wype18u8GUYN+YM9oaIE+HKw8LCaZzhRn/foap87elah40D1 n8DWZ6olJf7Qe/di1GzB7t5DJ/xJ3hrN18p2M4G0nsxMaxECN2B1zTwzSiOFSx/zvrSy vQsw== X-Forwarded-Encrypted: i=1; AJvYcCV2Sb5SdnGYGnbtFN6apAov/0U74ZtoimEBGLaUTwbx5qdEmYD+Rl1Rezh/2QT4A/7sEMU=@vger.kernel.org X-Gm-Message-State: AOJu0YzYcjAjsCB8T7otEtSWT8KlYP98gWQbrjMkwHnKfAlJ30IXzKBm 0j3Q3mmaG+FT3iXLQzaCx4JkPgFP0V/NbpGbbUrYhfd5yGGqVjtznluP1aQ8l3lYFUeqDNIIcoa qqPRcMFMdy7zVNilly5F1l1txrYeR8Vx5UNzpXmnWP2HB8t4bTg== X-Gm-Gg: ASbGncvvXJtf0oVZp2YaTR97G4CkDMu9H1laE6kwoB7uDe8lVgz4gDvkoVyPKdZO8Hh lTbRrI8qTI+ZW4m1R8A9bAlMU85TsIlWSMlIH1jIbG3LhZVSMwl+PC6AYijstBsfmzS7zWWOg8m mw+XKvA6t9odm6BnkZhChewUSrlw6wBZW0GCw19mNa0Yv2pa4PJBBGqZKoMJUvuepQ8ctiziaAI pwHq5PexrvTAfvcqQwJ8QA9gRS9jCl8J0nICYXMrNaCle+Xblg5P4hUNkEWDvNO5unSv+Pim6PZ 4FG43HvD X-Received: by 2002:a17:907:7ea6:b0:ac2:dfcf:3e09 with SMTP id a640c23a62f3a-aca9b719b0cmr234859866b.43.1744194974081; Wed, 09 Apr 2025 03:36:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQCZRAFJMcL3NkxF41e8trgIRpTjzQOtQoBDKD5Ijj+qm+kAuHuUYYu1XdMXJhDmFnpSmJJA== X-Received: by 2002:a17:907:7ea6:b0:ac2:dfcf:3e09 with SMTP id a640c23a62f3a-aca9b719b0cmr234857166b.43.1744194973699; Wed, 09 Apr 2025 03:36:13 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1cb43b6sm74653666b.93.2025.04.09.03.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 03:36:13 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DCF4B19920AD; Wed, 09 Apr 2025 12:36:11 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jakub Kicinski Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v8 1/2] page_pool: Move pp_magic check into helper functions In-Reply-To: <20250408121352.6a2349a9@kernel.org> References: <20250407-page-pool-track-dma-v8-0-da9500d4ba21@redhat.com> <20250407-page-pool-track-dma-v8-1-da9500d4ba21@redhat.com> <20250408121352.6a2349a9@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 09 Apr 2025 12:36:11 +0200 Message-ID: <87o6x5vcys.fsf@toke.dk> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jakub Kicinski writes: > On Mon, 07 Apr 2025 18:53:28 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index b7f13f087954bdccfe1e263d39a59bfd1d738ab6..6f9ef1634f75701ae0be146a= dd1ea2c11beb6e48 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -4248,4 +4248,25 @@ int arch_lock_shadow_stack_status(struct task_str= uct *t, unsigned long=20 > >> +static inline bool page_pool_page_is_pp(struct page *page) >> +{ >> + return false; >> +} >> +#endif >> + >> + > > extra empty line here > >> #endif /* _LINUX_MM_H */ >> diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types= .h >> index 36eb57d73abc6cfc601e700ca08be20fb8281055..31e6c5c6724b1cffbf5ad253= 5b3eaee5dec54d9d 100644 >> --- a/include/net/page_pool/types.h >> +++ b/include/net/page_pool/types.h >> @@ -264,6 +264,7 @@ void page_pool_destroy(struct page_pool *pool); >> void page_pool_use_xdp_mem(struct page_pool *pool, void (*disconnect)(v= oid *), >> const struct xdp_mem_info *mem); >> void page_pool_put_netmem_bulk(netmem_ref *data, u32 count); >> + > > and here Ugh, got sloppy when moving things around; sorry about that. Will respin. -Toke