BPF List
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn@kernel.org>
To: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: "Björn Töpel" <bjorn@rivosinc.com>,
	"Jean-Philippe Brucker" <jean-philippe@linaro.org>,
	linux-kselftest@vger.kernel.org,
	"Anders Roxell" <anders.roxell@linaro.org>,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Cross-compile bpftool
Date: Mon, 13 Feb 2023 15:30:48 +0100	[thread overview]
Message-ID: <87pmad63jb.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <20230210084326.1802597-1-bjorn@kernel.org>

Björn Töpel <bjorn@kernel.org> writes:

> From: Björn Töpel <bjorn@rivosinc.com>
>
> When the BPF selftests are cross-compiled, only the a host version of
> bpftool is built. This version of bpftool is used to generate various
> intermediates, e.g., skeletons.
>
> The test runners are also using bpftool. The Makefile will symlink
> bpftool from the selftest/bpf root, where the test runners will look
> for the tool:
>
>   | ...
>   | $(Q)ln -sf $(if $2,..,.)/tools/build/bpftool/bootstrap/bpftool \
>   |    $(OUTPUT)/$(if $2,$2/)bpftool
>
> There are two issues for cross-compilation builds:
>
>  1. There is no native (cross-compilation target) build of bpftool
>  2. The bootstrap variant of bpftool is never cross-compiled (by
>     design)
>
> Make sure that a native/cross-compiled version of bpftool is built,
> and if CROSS_COMPILE is set, symlink to the native/non-bootstrap
> version.

...and the grand master plan is to add BPF CI support for riscv64, where
this patch a prerequisite to [1]. I would suspect that other platforms
might benefit from cross-compilation builds as well.

[1] https://github.com/kernel-patches/vmtest/pull/194

  reply	other threads:[~2023-02-13 14:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10  8:43 [PATCH bpf-next] selftests/bpf: Cross-compile bpftool Björn Töpel
2023-02-13 14:30 ` Björn Töpel [this message]
2023-02-14  9:16   ` Zachary Leaf
2023-02-14  9:44     ` Björn Töpel
2023-02-13 20:53 ` Quentin Monnet
2023-02-14  9:46   ` Jean-Philippe Brucker
2023-02-14  8:57 ` Zachary Leaf
2023-02-14  9:41   ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmad63jb.fsf@all.your.base.are.belong.to.us \
    --to=bjorn@kernel.org \
    --cc=anders.roxell@linaro.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bjorn@rivosinc.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jean-philippe@linaro.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox