From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EDE61B3B23 for ; Thu, 29 Aug 2024 15:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724946999; cv=none; b=A0w7kTf3I1GhLaRMam3LciBBhRnK6p+xKdfJDwF4V4eCHtJSmZ1Tt7kcPEbCXYHHGYyw5QaRbAUsyXJzHw7tdyH9L0pXkgtdRvLiIc3uBveu9gEfv+SgE8HCoBEBPCZRZUjBdz26BiqFHdOplXFeELgkf48nUJO/w9/tIP7y4wo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724946999; c=relaxed/simple; bh=BBqKX133p9uAfTL/pwOLNDA/VyV9Sy6IKhFXpLLIDyw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=acGv9dKAL18RsnPiJcOd5O2jL+oZkUg37jFpJdXv+tQY8y8i3v9QKUdxNoZ33egUDtiILrdwErknVuMWpJ79DNNu1uIbExGFx4gMd4idduPlWMJ1vhYtVAfQjT1FcEOSGN3LVxSzhJeXQIQysV2/AXbBg5busZOsuaLRAbxkE3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=UYGeYzLO; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="UYGeYzLO" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2f50966c478so7824351fa.1 for ; Thu, 29 Aug 2024 08:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1724946995; x=1725551795; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=BBqKX133p9uAfTL/pwOLNDA/VyV9Sy6IKhFXpLLIDyw=; b=UYGeYzLOkCB+JendhzPh6b4eT1tVBt4dsIm6tOpuLKU4a1ZCvIXcLe4mmLq9c3QkwJ GRn2D/anmeBL3eeHEtCFSzi1Ns1pminDRyJiNjMrzqsR5qlHep351Hyr32QfIWauPHxy edsZxSJd/pk7BKlaqblCAg19zrUh1/+vtKvrzlkGs2QFOd2qlFCkUsiGCNIFqIzfJv7J CNpP74LkPJibVwm1qotWKuxqxbrFlfQwNFzYjljUmRo8ZqEgakEDUhVxzxu703IsvFaP Z2BxDfPf3EtRt/6AhYzi1umGREYQYZ0AVJ/hQZQIXOv3E0bQQFvNA8qU0vxTGAq1Gb6G vckQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724946995; x=1725551795; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BBqKX133p9uAfTL/pwOLNDA/VyV9Sy6IKhFXpLLIDyw=; b=OWCuD0Axspix7k4ycOJGH71LQ4OqCcGA50Pd8yXEqkf+6NP46OicaFUAYlQZhtYJew fuQE2z7u5lS0Ml7T2cxvWGIb76nL1aYk9qqjOP9e/isaFZJW0HXwxE1kOvAsOr5rsL1I 3r5mPMIMf+YxhlDQE2upY6iXF86Ca4dDwuPuYj4ry1xww0zaJRXYudqijHROA9oswJlU bdSw6KszFJAXssldF9f29WJJxB8ey5pu6Pcbfk9f2BfKcZ0IGnJSjyhuqLfp0zHi2cVe 4TYpgSXfPgfJe6j6OgzxGkeGmr9IqFxqpG0mB+uVx+66aFlz6ncn0nUKBCB9zF8aRhXA Kmog== X-Forwarded-Encrypted: i=1; AJvYcCX+um5XKlDXQnkOgJIz8at2D+KGrFQW8Tmw97PyFZsv1PKwtNV5ImRjIsgGrKx0ib5plV0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4JR1fcP5CymNW/Ty2UUYZBZlhjkBNNyNDePhiNmSihUtuoUME 2I9TVOdV3AQTk24+AYeAfV8HteYqVfuuqHHKd6hJSgHhYuRMxci+sjFPPcnQSpI= X-Google-Smtp-Source: AGHT+IH/TF/DXk+LKRSXXVi35QIzFpLF5dSEeiLFij7z4Dzn16uZrsamMOWW4Y8gBHG3t15eAvBs8Q== X-Received: by 2002:a05:6512:4003:b0:530:aea3:4659 with SMTP id 2adb3069b0e04-5353e54736amr2047454e87.9.1724946995032; Thu, 29 Aug 2024 08:56:35 -0700 (PDT) Received: from cloudflare.com ([2a09:bac5:5063:2387::38a:4e]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a898900f055sm94706966b.67.2024.08.29.08.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 08:56:34 -0700 (PDT) From: Jakub Sitnicki To: Yaxin Chen Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, Cong Wang , John Fastabend Subject: Re: [Patch net-next] tcp_bpf: remove an unused parameter for bpf_tcp_ingress() In-Reply-To: <20240823224843.1985277-1-yaxin.chen1@bytedance.com> (Yaxin Chen's message of "Fri, 23 Aug 2024 15:48:43 -0700") References: <20240823224843.1985277-1-yaxin.chen1@bytedance.com> User-Agent: mu4e 1.12.4; emacs 29.1 Date: Thu, 29 Aug 2024 17:56:33 +0200 Message-ID: <87r0a7uxu6.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Aug 23, 2024 at 03:48 PM -07, Yaxin Chen wrote: > Parameter flags is not used in bpf_tcp_ingress(). > > Reviewed-by: Cong Wang > Cc: John Fastabend > Cc: Jakub Sitnicki > Signed-off-by: Yaxin Chen > --- First introduced in commit 8934ce2fd081 ("bpf: sockmap redirect ingress support") [1]. Looks like it was never in use from the beginning. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8934ce2fd08171e8605f7fada91ee7619fe17ab8 Acked-by: Jakub Sitnicki