From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D06EC4332F for ; Wed, 14 Dec 2022 00:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237653AbiLNAba (ORCPT ); Tue, 13 Dec 2022 19:31:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237649AbiLNAb3 (ORCPT ); Tue, 13 Dec 2022 19:31:29 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D4B613DDC for ; Tue, 13 Dec 2022 16:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670977841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5/DKXnmJkH8N016jW/1YR9trr0KMuzerJfu4aLg0h/g=; b=LeGeow8pa9ZYFxsM1TGmil3JsMyAo5V1e654tJBL5MuMon4k8/VMqw95DbI7Fkk5NqCU+q aCI8Wi1sAxjjANuMj/EBHPdXdpa1KmIEsIHazgBIN+hxNJx/XCmh4a3vMDt3c3k1y5LOTj 0HSdo2GBAV+2Lf83EXxNxCMubP82fWw= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-628-dqsw0k-kPZiFHPk3udMY4A-1; Tue, 13 Dec 2022 19:30:40 -0500 X-MC-Unique: dqsw0k-kPZiFHPk3udMY4A-1 Received: by mail-ed1-f70.google.com with SMTP id s13-20020a056402520d00b0046c78433b54so8307626edd.16 for ; Tue, 13 Dec 2022 16:30:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5/DKXnmJkH8N016jW/1YR9trr0KMuzerJfu4aLg0h/g=; b=sLdVtsayecbzs1BbMPHwE6c1/Gpvk3FJxcrgWzwiY9TRJVTkaS/geAM4L7SvPmHj/B QfWAwYk/Iu1rZuS86jjJfbeY+h3wNmhObC/gQy8Pkg0nCMOx+CDqZUpKHMjm63ySKzM5 PTUGlTR+vVYdADNdbAAZIKsK+1OlceA7fjHE3aWgi4uiXoi3uYOvSp9OrO4RW3OjezaZ MIo1LwdNiBk2cxdICBBcbzRtAw7YaePa7FZRfqhwjjeyWN0L0xClgwSBgvnjP7UgJCen eSUkGNzw/gdYNE/6Dy8JZCQlIfmmdVvVtr82fvxFCLV1uIFxssqtAjeN0gsx6QekkQZk XvUQ== X-Gm-Message-State: ANoB5pnUIV4sLTmpLJTCCSHElxjjXM07pc0G4nCBY8B+Rqxe33tRspcR Hieg3YSR/VIdY2uJqzMYmWV/Z9w9Zv/hAPZndXTYrNgO95Ie/Mg2SwMjc5Tn1YFFpJVYP4vSLtz e7HjOZSl4HFqn X-Received: by 2002:a17:906:5a87:b0:7c1:962e:cf24 with SMTP id l7-20020a1709065a8700b007c1962ecf24mr3056246ejq.50.1670977838817; Tue, 13 Dec 2022 16:30:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Sa6XkMcSkNV/JP3TsVUZAOpfdGZylfeDnpVOOclMkVkNySPr4qBDk65ovykUjrlKdSgYFUg== X-Received: by 2002:a17:906:5a87:b0:7c1:962e:cf24 with SMTP id l7-20020a1709065a8700b007c1962ecf24mr3056220ejq.50.1670977838504; Tue, 13 Dec 2022 16:30:38 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id u18-20020a170906069200b007ad84cf1346sm5072862ejb.110.2022.12.13.16.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 16:30:36 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 7480282F40E; Wed, 14 Dec 2022 01:30:35 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko Cc: Andrii Nakryiko , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Shuah Khan , bpf@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH bpf v3 2/2] selftests/bpf: Add a test for using a cpumap from an freplace-to-XDP program In-Reply-To: References: <20221213232441.652313-1-toke@redhat.com> <20221213232441.652313-2-toke@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 14 Dec 2022 01:30:35 +0100 Message-ID: <87r0x2hln8.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Andrii Nakryiko writes: > On Tue, Dec 13, 2022 at 3:24 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >> This adds a simple test for inserting an XDP program into a cpumap that = is >> "owned" by an XDP program that was loaded as PROG_TYPE_EXT (as libxdp >> does). Prior to the kernel fix this would fail because the map type >> ownership would be set to PROG_TYPE_EXT instead of being resolved to >> PROG_TYPE_XDP. >> >> v3: >> - Update comment to better explain the cause >> - Add Yonghong's ACK >> >> Acked-by: Yonghong Song >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> --- > > what a race, I just replied a few minutes ago on your v2. Let's use > modern BPF skeleton approach instead of adding legacy stuff to > testing_helpers Sure, will respin... -Toke