From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@fb.com>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH bpf-next] libbpf: Add libbpf_set_log_level() function to adjust logging
Date: Sun, 27 Oct 2019 21:55:15 +0100 [thread overview]
Message-ID: <87r22xsybw.fsf@toke.dk> (raw)
In-Reply-To: <CAEf4BzYC6U-QC48nRkicb9YHNt+6xPkQAmTZcoEFt+u_vkExYw@mail.gmail.com>
Andrii Nakryiko <andrii.nakryiko@gmail.com> writes:
> On Sun, Oct 27, 2019 at 4:08 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>>
>> Andrii Nakryiko <andrii.nakryiko@gmail.com> writes:
>>
>> > On Fri, Oct 25, 2019 at 4:50 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>> >>
>> >> Currently, the only way to change the logging output of libbpf is to
>> >> override the print function with libbpf_set_print(). This is somewhat
>> >> cumbersome if one just wants to change the logging level (e.g., to enable
>> >
>> > No, it's not.
>>
>> Yes, it is :)
>
> As much fun as it is to keep exchanging subjective statements, I won't
> do that.
Heh, yeah. Even though I think the current behaviour is incredibly
annoying, it's also somewhat of a bikeshedding issue, so let's just
agree to disagree on this, drop this patch and move on :)
-Toke
prev parent reply other threads:[~2019-10-27 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 13:21 [PATCH bpf-next] libbpf: Add libbpf_set_log_level() function to adjust logging Toke Høiland-Jørgensen
2019-10-25 16:58 ` Andrii Nakryiko
2019-10-27 11:08 ` Toke Høiland-Jørgensen
2019-10-27 20:00 ` Andrii Nakryiko
2019-10-27 20:55 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r22xsybw.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox