From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A622EC43461 for ; Wed, 16 Sep 2020 21:08:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 374BF206DB for ; Wed, 16 Sep 2020 21:08:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FoA6kLZO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726540AbgIPVIM (ORCPT ); Wed, 16 Sep 2020 17:08:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35160 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726338AbgIPVID (ORCPT ); Wed, 16 Sep 2020 17:08:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600290473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/54H5boGPOw6PIuMrJAthQBR69fhyyzb/6j3eNXf2IE=; b=FoA6kLZOdNjTLmTSSevka76r83XUDHR+jLFl82/p7YTKMUKT6U6whtA6fj0lJL8GDcYBB3 QuPt/Yjly9Lqjfs16NYoOmSW0FcTL/zWz8BxDmz8YSwb11rSNGPqBitk8Xd1CmK1rXuBuM u6FXoGmIJW1oCtXzMEuVzx9izH7YFSY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-a_pgeCAtOfShxASuW4_37A-1; Wed, 16 Sep 2020 17:07:51 -0400 X-MC-Unique: a_pgeCAtOfShxASuW4_37A-1 Received: by mail-wr1-f70.google.com with SMTP id l9so3009940wrq.20 for ; Wed, 16 Sep 2020 14:07:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=/54H5boGPOw6PIuMrJAthQBR69fhyyzb/6j3eNXf2IE=; b=EV+yY5yYKQvAQtP0ABIN0FHKvOpIOuOvLv41fdt8epjwBuzkmevuLAIy8D5aEBHf+5 Y6B0mwZhc4EGuyxTgfVOaOhPja7hU5vkx6SfD7Tdnqb3ScN1Bt6H2hZeLvCiHCNbCdA7 SN81PmtARJFQCxbPtqcwgzimn44xuBBLP37RQWPCIoMUcxDxIb1xNbP2234g9EVmvQK6 4qgD0xSeJ94C+QLh+oKrj4CeJJ4Yw0R6x5qSgtmGh2lHFxXnTTQ14VXUohsl2ejquwG1 fVPFEQN0f4UoCEqqEKTIKnLqahkmSMSbWH9hPZHugDxvMAnxon3byYqoW7vSqRsKJ8hx gmJA== X-Gm-Message-State: AOAM533aIN6WU0h3Y31urMaQLWCHUz+aX+Y4S8KRh2PWjPYv3loxzJ8l nq1QZCP4pLxEnA1oxKjGde5Gh0IPFnYEUHzLJBJZ4U8NvjlXSijXoXn3gKSrLNns/q2h6Z2R5Uo JllvG1IwzY1Ny X-Received: by 2002:a5d:6291:: with SMTP id k17mr28325415wru.130.1600290470607; Wed, 16 Sep 2020 14:07:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRIpLByKR9vlbbyb4rveY1q0jSfOuRdwKkvCTSqfg5buShe2kGa0NkbbkTrTS5aEe33zZZeg== X-Received: by 2002:a5d:6291:: with SMTP id k17mr28325397wru.130.1600290470314; Wed, 16 Sep 2020 14:07:50 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id w81sm7606143wmg.47.2020.09.16.14.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 14:07:49 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 2DDAE183A90; Wed, 16 Sep 2020 23:07:49 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , Jiri Olsa , Eelco Chaudron , KP Singh , Networking , bpf Subject: Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id() In-Reply-To: References: <160017005691.98230.13648200635390228683.stgit@toke.dk> <160017005916.98230.1736872862729846213.stgit@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 16 Sep 2020 23:07:49 +0200 Message-ID: <87tuvxph0a.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Andrii Nakryiko writes: > On Tue, Sep 15, 2020 at 5:50 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >> From: Toke H=C3=B8iland-J=C3=B8rgensen >> >> The check_attach_btf_id() function really does three things: >> >> 1. It performs a bunch of checks on the program to ensure that the >> attachment is valid. >> >> 2. It stores a bunch of state about the attachment being requested in >> the verifier environment and struct bpf_prog objects. >> >> 3. It allocates a trampoline for the attachment. >> >> This patch splits out (1.) and (3.) into separate functions in preparati= on >> for reusing them when the actual attachment is happening (in the >> raw_tracepoint_open syscall operation), which will allow tracing programs >> to have multiple (compatible) attachments. >> >> No functional change is intended with this patch. >> >> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >> --- > > I almost acked this, but found a problem at the very last moment. See > below, along with few more comments while I have enough context in my > head. Right, will fix, thanks! > BTW, for whatever reason your patches arrived with a 12 hour delay > yesterday (cover letter received at 5am, while patches arrived at > 6pm), don't know if its vger or gmail... Ugh, sorry about that. I think it's an interaction between vger and the Red Hat corporate mail proxy - it's really a mess. I'll try switching my patch submissions to use a different SMTP server... -Toke