From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 638A716D33B for ; Tue, 7 May 2024 18:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715105660; cv=fail; b=ECwYomGUWubcNYVCb1O0ug7Ttq0OnAz24YIJ+7aBrM9gUmdy6PtTg7ggMcPFHWYiEGHYYiGqf/SCwn3mrZGrCBksDdNLt+ZOjf9JoSWQIu7M+DM8nA7+j90i9FRPE49suU+8bvRPcRcz+sgB+qibglnKXHDKqgImljQ0BTk2uAk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715105660; c=relaxed/simple; bh=UqIZ2MOnC3qNv9dADJlhtzQ3HUpVAtWwl6qxKZKLnhs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: Content-Type:MIME-Version; b=jIjFEnuw1DDSNo8Ajzpi2NAXJf7hnkUCudRd2EACa3nVZffluz61mMQtqnxwqS8Jqr4OdyBCQVPMyNs3LgMsJkc9+WIz0g3dJfqj87BEoeCQteHUiBHlGGATSuW6I5T90tcTAe2R23dkIr3jET+A2WmwGrCAEf4h2HahQdsldaY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=XrPa8gIJ; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=RkQ9OpNS; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="XrPa8gIJ"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="RkQ9OpNS" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 447GPOec021751; Tue, 7 May 2024 18:14:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=Sz5ZnjQ+OwMyGZtM9vBoMv3MEulVPrOlFWSjvsxXry8=; b=XrPa8gIJ2XKIF3RMpoxUd9UCXZDMcAf1dXNaCZG29h/vQ4JbehFAuLZxZM+LPcnAcrYN knWGHUAugXc25bJcZtQiaS0Ru+c0vsc2gaaWi/VWpUubYpbSsLaih2qfwUXLwGMWBiQT /YWbqLKXp4zEGD5xNwDX3yQ1RB+ZLMA3892bGBJIRK6T74mifoF6XYW/D+DDgLFBVDEL CrmFrHkSgTr8ZGDugjavjRSY2b2eoDvHsQCJdZJ7TK6rPBSyHN78ZPXl64MsbzAV2EdQ cO0n/PBqPt1vMWApGRgstqLBJ2A8M1Y+RrlT2U1NEXctHNU9w5+j48F5ryu1a2Uw2p+u mw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xwbm5nsq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 May 2024 18:14:12 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 447HdObA006974; Tue, 7 May 2024 18:14:12 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xwbf8drxf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 May 2024 18:14:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hXzksq36jUq4qxRcPOdLp8CHoLpbCEnx7n+A0wOJn/H/CKOm9aA9kJ1FsOK4Rkd5PnBmbN811o7Brn+H3TrvjREnXn0Zxgff7qYJQqL81AXgbFR5Urtp58saxFC78xiI5g7/XtgEOH/0LsSMDmnVMNYwCQ94VCcIu8u0SrstgwAzP3vp6OqJNBWeJJf8APqmXtvUmmDPuHmk+p9CFeLzgm6MjBuqM6/OGvfXcD17CammgneqJp6fQwhtbcay9i39wf73N4h0WkF34W/Spxgm3bi7AuCk305OUa8wm3uIY7AY1I5knsrvgEf8ws7HmutVzUS+rOYY7wBMJK7CFNB4Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sz5ZnjQ+OwMyGZtM9vBoMv3MEulVPrOlFWSjvsxXry8=; b=WhNFkqBmCYqEW8S1xnPx8nZz9t+/Za7XTxfawE7uLn5HyzAREA2ciUpZx8lL4M0nmrpoVzaxPZSUt6/uLfYujuhozwGGejwJI1rn2LqzH9+0l9PE0h8eMuK4nTs2xDOD7Lw4IR/B/7VBhEeSj7dec/uR1Gk+r1ZUfeg6zYvalPBVQAAm5mAMyjkkptf860CBF1MV1J8N/dMQ7rPm7d01NHBgKLT0f75eKbR0e6Ed2/5FpBIYWCZgKBu59cc9F0Rii2u1x+VVskWYEgXD+LxSfnphb9vTOtrIipeHosntS7gnXtE09tkzhe2/feXnIOK4ICRLOQgrE8uqG58s6fWReA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sz5ZnjQ+OwMyGZtM9vBoMv3MEulVPrOlFWSjvsxXry8=; b=RkQ9OpNSxzndpcQlpmd7xo4zc9wkCD2TgxuV1EirOoBU0rBkR7NMHpwtB77t6cgZbWgMsOH8VtqVSNF2FJJrWLiIElnDgwru6M+ePEtzYKzPznpm1rw9EcVWsBq22ZMcKZkisJARn+trN2ILMqjXaMEAxp3L5wyEqG9GYwgv5IQ= Received: from DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) by BN0PR10MB5128.namprd10.prod.outlook.com (2603:10b6:408:117::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.43; Tue, 7 May 2024 18:14:09 +0000 Received: from DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::e0b9:12d5:badd:6fe0]) by DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::e0b9:12d5:badd:6fe0%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 18:14:08 +0000 From: "Jose E. Marchesi" To: Andrii Nakryiko Cc: bpf@vger.kernel.org, david.faust@oracle.com, cupertino.miranda@oracle.com, Eduard Zingerman , Yonghong Song Subject: Re: [PATCH bpf-next] bpf: avoid uninitialized value in BPF_CORE_READ_BITFIELD In-Reply-To: (Andrii Nakryiko's message of "Tue, 7 May 2024 09:41:47 -0700") References: <20240507113950.28208-1-jose.marchesi@oracle.com> Date: Tue, 07 May 2024 20:14:04 +0200 Message-ID: <87v83pcwwj.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0338.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::19) To DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3113:EE_|BN0PR10MB5128:EE_ X-MS-Office365-Filtering-Correlation-Id: d037e40f-f0b6-4a5f-4373-08dc6ec17d11 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VEU3N2M3ZFBRdkxFMk91S2Z6eDVpMWJ6Y1VkeXNWWW9TVFJBaHJJM0V2ZENF?= =?utf-8?B?by9iTzFFVFBWNmhGRzZhT3F3SmxLZzNuSXpSSHExLytZU25Yc0VGV0dubXNN?= =?utf-8?B?YWZkQ2I4Zzhsc3pwbGNhNm5LbXZoY1RJTTZIdm5nTVdieTNhRkpsOTdMaTJW?= =?utf-8?B?eTU2MDhsdmx5cVEyOWpmOHFJZHpWYnhHNS9iYmRHSWhIelAxcmtVYXppbVdl?= =?utf-8?B?S2N1RUVNb1EreEtGaEhtazRjZVJjWWREZlBocm5CZ2U2eUo1VnZpZlovYzBS?= =?utf-8?B?aU02bDlqODdIc2U0a1M0Qk9nN3I4aW84VjFETnhvZGFlVTB3Y2ZqMFBRQ3Q5?= =?utf-8?B?emJQaXRyc1k3MkNWbDhvN29ucm1hZ2d4ME1SRVlNbXF3VDhqdEg1U2FvbGUz?= =?utf-8?B?ZGpsUEpRU0t2RlpGZHBFcC80K0NGdEE4cUxQQlBsV29YMTRnV2YyNm5YbW9N?= =?utf-8?B?TE5SdUgwTFVOMHVoVU9pYkt4Q1ljY0Vackk3WjRlcXR1anJFN1JFamNnRGgy?= =?utf-8?B?VDI4dFBPOGNTTXF1R2crWC81UHczeTI2aVhTMm00SXBVbFVOV1dkUCtRK3ZY?= =?utf-8?B?OTBHb0VkVXc4U2pVamVTVGkxbVpEQkdFTFNGTmIzYjNMWmtOd0VhS3Q2Rzha?= =?utf-8?B?ZEJxM2syM0paMjQ5dW1uczh5K01IQlFkMDN1WEVtdnJLWEdPYmdEaXg5RnNS?= =?utf-8?B?VFUwVk9ZR0diYk1FTFlTWjI5UTlYL1haOGVaN0cxOWtxbnZWT2xCVjhjU2F6?= =?utf-8?B?UmNlUjE1MU92aUJwYXo0Y1lmNFRyUlBQdE4ycWx3aFJoNHlCRXJ3cTVOdW5T?= =?utf-8?B?T1BGWXcwWDNlSzg1N3ovM0dRNlUxd3U3VzFjZFNUdUdXNk1rcnFlUjhGOVZU?= =?utf-8?B?cWROTi9tQ3g1M3ViRjJKek1ESklDRXpQSlpQMlVKRlZIUEhWcjhQUDBPdFJa?= =?utf-8?B?eTFTNlNlc3FHNk9XSlIvQnhmZERGd0M2Rnk0eE8vMlUrY2lwZ3M3SEh2ajlB?= =?utf-8?B?OFIrUnlHKzhWUHF5dHduSi9CTEZRZDJhVXZWUkkzdEd3VlRsOUJOTGVkdG16?= =?utf-8?B?K2lGU3JKdFcrVzRHQlg1bGtlaUVURDJ1bVBCTzNJRWdINUFWZkJvREdjbTVv?= =?utf-8?B?ZEkzYmtCOVNycHhJUFoyL2xUMXc5U21CUFN2R280d0NFKzVmellScGVyK2Nz?= =?utf-8?B?cUc0MWliSUVTb0UydkRLcElGdU5mTFdZVFJwcHd5Z3hVVUxDVGl4N2Z3eFBB?= =?utf-8?B?bVZ4SEJXbmFyRDdVVnNiZWlSMHh5Nk5nZm13SzhBUnBoaEVvVjQwMzZTdlFz?= =?utf-8?B?a3g5MnB4NXNTNkZtOXo2UlFxZmJVQ1dNSXFCcmUvYTg2OTB0aWtlR2xoeVdi?= =?utf-8?B?cDZsclBKRjdmbFlXeFY0UmI3NDRmQVlWSi9ZcGRLNG1pbW4rbGtWOW9SRkpR?= =?utf-8?B?TUY2Vi9xK0J2dFFOdjRWblBmOXpMSXUwUitjZXpZNGtvT0FtdERJNEJXaHdG?= =?utf-8?B?c0pTSkg0TDFEbHdVYVpSS08zdzJ0UEJIM2VpanJYaTBlejF5aUdhbEEzdEV1?= =?utf-8?B?TXFnM1ZXVmROUW8wYjFQUHE2R245MXZ4V0NOb1dndzBxNzJycExEQnpsa0tv?= =?utf-8?B?anRFTk0zTlVJM3k3em1yeGlZSE9mK3AzUlZiUU9maVV5NEpINHpqTFBoSFpv?= =?utf-8?B?MzFaSm03UTNDYlY5YllZTFpCcVUvZUhzanJ3eG41bmx6N2xDb1Z1bmNBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVBINnk0UkJVTVRDalR1TnZ6L0NrWmtMTVRyQ2tTbE52Y0E2WkFIdjZ3VWhi?= =?utf-8?B?U2dqS2pPbTJ6UFJSbGFuQUlTTzNPNmRqWUxMTEREaXhqL3R5ZlVFc0I0ZndV?= =?utf-8?B?NFdxV3NuMWVvVTJTZGY4a3h6K1pvTFFqT0ZudUtFR1hQbUQ1cm5oZkdGUzVn?= =?utf-8?B?M3I0MWxYOGhQenJSbGlzSW9Lc3hwNDZsOGY2RXVMYmhrWFJPUEVOMDh4RVdr?= =?utf-8?B?SzA5QXUyWmY1YkZiZDRsZGU5YStmSkZoSkd0RHhKbkgxTUpEWHVNazcyUExH?= =?utf-8?B?YldGZnRMSTFGKzl3UzJLUlJ0T1JFcHJrWkZwNW1jNXlScWlwc1NGV205RkxJ?= =?utf-8?B?TjU5MWlIMmFJaXA4Wm5TVXFDd1dMZDFWajdCQzhMbFZqK0J6ZTBIR2RzSjQ5?= =?utf-8?B?UE0ybXBUQUpoanFtWk5uUGtuNGxaQ1V4blY5NHQyeGFIQjZTbFVRTER4UUR4?= =?utf-8?B?bUdUYlp3eGR5akIxcFMybnNrMXZ6QkNXSVFWNjZ0RHo5TzhYVzFSRXZWYUtr?= =?utf-8?B?MnZpcnJMb1ZYN2FTMTVvK2ZxUXRVOWNHYWgzT0FUMWhxQXBLMm16TCtmbUVZ?= =?utf-8?B?aVVzZytwUzc2V0o0T3R5OGdPTUtNVjQyalRDdnZpUm81WmRzbjl2aFlPYjZP?= =?utf-8?B?TStvV1VrWngzWFJxeitOM3cvWWIxdENLZFRwU2pPL1pZVmRRZ3B1d3dxVXZO?= =?utf-8?B?STVTZU1GNEtuOVJTODR1SE9xY3lKS1h3c051VzRCU2NxRG02UG54SFZpOGpB?= =?utf-8?B?TDJKNjR1WW10VWlLVHpvM1orbmN6SW02aWx6d05kVkJlNkZZM3FGb2JQOGxN?= =?utf-8?B?cGdOMDBBbmNQMHBUOEgyZkpOcldBUjFJNTlTUzJMU0FlMDd2WTVlT0YwMkts?= =?utf-8?B?TEloY0s2OFZib2J5dktCZnJTVDhjcElYMk1DZUdlMjJtd0orRXBTVUNEVEZM?= =?utf-8?B?T2NoSVF2YjFwR0kySHNMNnYxZW5QL1BydXhnWm5qNC90OGUrL3ZzdGVKSC9n?= =?utf-8?B?N3RkSGUrZ3NqeXh4M1ZvYnhWSG83S0R4NndkcU5jbHpMNnhPTVJXTlE4TkVa?= =?utf-8?B?TFpjVk0wUllyMHdwU2hmMFFHVmNZTlc1Z1VDMGdlQmFsYzlCc3B4R3hBNG5T?= =?utf-8?B?QmJTOCtYTmxHWFJTWkhaVUxnL0x6aFJBTHp1aUlCZUdLYk1xSUEyQ3lVMGMw?= =?utf-8?B?VFRwVE8za2V0cVBYanBFV3pXeWh6M2dZQkJDVGkvK3Z1ZHk1Tnp4dkkvUGla?= =?utf-8?B?eVlnekp4alNQQ0JxUUJLNS9BZjZvZjRpVXZadm1PVzZZRzJWaDhKY2I5QmVT?= =?utf-8?B?ZXRXTVA5L241cjh5T2krNkFOV3NMOFVNNzJkbkJIUm1BNURyTFVMN0N5Zjd2?= =?utf-8?B?VWJ3aVVCZ3JMa0E1RXNyVm1sRmZlTWRUbmpqZGxPb0tRaHByUWJqYUJ1Sldy?= =?utf-8?B?VjVFUnZlWFVIRCtldnlEd2VoeEJLY3VGQnNqNHZHK0gxWXY0NXNEeCtQaEZP?= =?utf-8?B?U1QrMTFWdXRUSXVacDA1cWFEWjg1MHJ1eGdEcE5odzR4VGZET3hvUjlJOGdl?= =?utf-8?B?VGxqQVhHR1F5WklaUGx0ck13OW4rZjJpL2dzV0pndzVxdEo4ZEVFanQzaEdY?= =?utf-8?B?YkRpR1BoYUFNYWhyNW5OTnZKSUhaakFyV0dIdEJBY3g1aTJIOXEvY2lObDRI?= =?utf-8?B?VmxKL3dDNE5VdS9wbjRncGpJL1JsZVpWWUd6MUJCNCs2N1E5NnNsK0xobmNh?= =?utf-8?B?SmlaK3NoL2VQa3RSVWtWcFNKcjF3TXdTSG9IN09KV1JoVmdYYXRBTW1lSk9n?= =?utf-8?B?OWpINVIxYXZhNzhqUUZSUWhiTTVuVTFRNzB0WHZ6NTZ0UEM2OHlXRFdrUjU3?= =?utf-8?B?ZHZ1K3BVemt4Ym5lWnFnWDNrYkV0ZVlUSVFaV0dFdktTZVRHWnBjbjhnUGFP?= =?utf-8?B?NkY3SENXQWdmcGVYNEtGMTZHMlNPaVExRXFmMTl0RUo0bFFSTkVicTA4MXBP?= =?utf-8?B?MVk4V3EyTlpzNmxGWStQQmVPSnYvOFNXTnpwcCt5NlZ0VWJZbzZEcUFlTU40?= =?utf-8?B?SWxCb0poTDRBUzdZWUhzcVlUcUtYMFh3cFdheVV0THRYa0ZnbHRCdU1hd3Nq?= =?utf-8?B?aVBGWDhLdlgrbnlWSGdEV210MW9vempuRzQxRXAyaW5SMkRLeTluWXBJNDgv?= =?utf-8?B?eGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tHxlnuRPWk3sbCrP3a92JGRhohQBtv8gRNm4c6Yka76qVPe0/2XLqG7isrA9NavltbL7GzVmvMbc3NEHDouH8csEhAn27pTA2CbqqOAyhAlmJ8z8jU3PpquoPjOnrWV81sFGv4AMeZdI+ZHUFSvZ6e1enphGOIaV67q5pxgfXE1vkuw1GvwjK6jaxH2nIXJPEVao8f5J64JVxsHg+rcp2OELkFJas0D0wMyhYr90JEBuJ4G6j0zjGUh+pVMLzEpTMl8laHXbNV9tpztGo1oaklZ1VGlXb406o9oXuTLrMsrZz3J3K+LRJQk92LhTJk9wy+rhGBdsDfOEGaGJ7dMJG9RZdkhSEywoRU1oRWUFjAhJLfuIKca0adBOm5HUejC4ETE6N09d9pDW5Ff7tg84xbv8Oh93hTehzaQ1bEmjV8n/izQpjN8jvndrQqwPVy0LxImMvoGqj/g0f4XiNC3PUsZM6FjYm9xkiMZqZeVVgt2w9Nm8PhNb5HIA/ijcB6Ozqu+863GytqWj506fsIzdCBTz35omqFrowm15QnVPahVfKP5djXum4KS4xru2mhE+IBVPpQsr+jNdY94exwhDUMb1L0N56aIjLtTbcDctdf8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d037e40f-f0b6-4a5f-4373-08dc6ec17d11 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 18:14:08.7665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xucVGljciQdaIDOgCqGdWyGueSzIN6aupN6zLsOAbC4fDbaOCTqTf4TymsKngyPnmsS0pWI+U3vRmEIGMMH+nI7J66JIpJOYY5qmE3KVXQM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5128 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-07_10,2024-05-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2405070127 X-Proofpoint-GUID: nwg0xsb_n_e4Hb0QAsbwWMjzi5c1z5B4 X-Proofpoint-ORIG-GUID: nwg0xsb_n_e4Hb0QAsbwWMjzi5c1z5B4 > On Tue, May 7, 2024 at 4:40=E2=80=AFAM Jose E. Marchesi > wrote: >> >> GCC warns that `val' may be used uninitialized in the >> BPF_CORE_READ_BITFIELD macro, defined in bpf_core_read.h as: >> >> [...] >> unsigned long long val; = \ >> [...] = \ >> switch (__CORE_RELO(s, field, BYTE_SIZE)) { = \ >> case 1: val =3D *(const unsigned char *)p; break; = \ >> case 2: val =3D *(const unsigned short *)p; break; = \ >> case 4: val =3D *(const unsigned int *)p; break; = \ >> case 8: val =3D *(const unsigned long long *)p; break; = \ >> } = \ >> [...] >> val; = \ >> } = \ >> >> This patch initializes `val' to zero in order to avoid the warning, >> and random values to be used in case __builtin_preserve_field_info >> returns unexpected values for BPF_FIELD_BYTE_SIZE. >> >> Tested in bpf-next master. >> No regressions. >> >> Signed-off-by: Jose E. Marchesi >> Cc: david.faust@oracle.com >> Cc: cupertino.miranda@oracle.com >> Cc: Eduard Zingerman >> Cc: Yonghong Song >> --- >> tools/lib/bpf/bpf_core_read.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/lib/bpf/bpf_core_read.h b/tools/lib/bpf/bpf_core_read= .h >> index b5c7ce5c243a..88d129b5f0a1 100644 >> --- a/tools/lib/bpf/bpf_core_read.h >> +++ b/tools/lib/bpf/bpf_core_read.h >> @@ -89,7 +89,7 @@ enum bpf_enum_value_kind { >> */ >> #define BPF_CORE_READ_BITFIELD(s, field) ({ = \ >> const void *p =3D (const void *)s + __CORE_RELO(s, field, BYTE_O= FFSET); \ >> - unsigned long long val; = \ >> + unsigned long long val =3D 0; = \ > > let's add instead `default: val =3D 0; break;` > > as Yonghong mentioned, it's not expected to have invalid byte size > value in the relocation Ok. I will send a V2 with that change. > pw-bot: cr > >> = \ >> /* This is a so-called barrier_var() operation that makes specif= ied \ >> * variable "a black box" for optimizing compiler. = \ >> -- >> 2.30.2 >> >>