From: Jakub Sitnicki <jakub@cloudflare.com>
To: Pengcheng Yang <yangpc@wangsu.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
John Fastabend <john.fastabend@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Lorenz Bauer <lmb@cloudflare.com>
Subject: Re: [PATCH bpf v3 0/4] bpf, sockmap: Fix some issues with using apply_bytes
Date: Tue, 29 Nov 2022 20:14:45 +0100 [thread overview]
Message-ID: <87v8mxa7wv.fsf@cloudflare.com> (raw)
In-Reply-To: <1669718441-2654-1-git-send-email-yangpc@wangsu.com>
On Tue, Nov 29, 2022 at 06:40 PM +08, Pengcheng Yang wrote:
> Patch 1~3 fixes three issues with using apply_bytes when redirecting.
> Patch 4 adds ingress tests for txmsg with apply_bytes in selftests.
>
> Thanks to John Fastabend and Jakub Sitnicki for correct solution.
>
> ---
> Changes in v3:
> *Patch 2: Rename 'flags', modify based on Jakub Sitnicki's patch
>
> Changes in v2:
> *Patch 2: Clear psock->flags explicitly before releasing the sock lock
>
> Pengcheng Yang (4):
> bpf, sockmap: Fix repeated calls to sock_put() when msg has more_data
> bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes
> bpf, sockmap: Fix data loss caused by using apply_bytes on ingress
> redirect
> selftests/bpf: Add ingress tests for txmsg with apply_bytes
>
> include/linux/skmsg.h | 1 +
> include/net/tcp.h | 4 ++--
> net/core/skmsg.c | 9 ++++++---
> net/ipv4/tcp_bpf.c | 19 ++++++++++++-------
> net/tls/tls_sw.c | 6 ++++--
> tools/testing/selftests/bpf/test_sockmap.c | 18 ++++++++++++++++++
> 6 files changed, 43 insertions(+), 14 deletions(-)
Thanks for the fixes, Pengcheng.
For the series:
Acked-by: Jakub Sitnicki <jakub@cloudflare.com>
next prev parent reply other threads:[~2022-11-29 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 10:40 [PATCH bpf v3 0/4] bpf, sockmap: Fix some issues with using apply_bytes Pengcheng Yang
2022-11-29 10:40 ` [PATCH bpf v3 1/4] bpf, sockmap: Fix repeated calls to sock_put() when msg has more_data Pengcheng Yang
2022-11-29 10:40 ` [PATCH bpf v3 2/4] bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes Pengcheng Yang
2022-11-29 10:40 ` [PATCH bpf v3 3/4] bpf, sockmap: Fix data loss caused by using apply_bytes on ingress redirect Pengcheng Yang
2022-11-29 10:40 ` [PATCH bpf v3 4/4] selftests/bpf: Add ingress tests for txmsg with apply_bytes Pengcheng Yang
2022-11-29 19:14 ` Jakub Sitnicki [this message]
2022-12-01 0:10 ` [PATCH bpf v3 0/4] bpf, sockmap: Fix some issues with using apply_bytes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8mxa7wv.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=yangpc@wangsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox