From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C4515FCFB for ; Mon, 27 May 2024 19:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716838596; cv=none; b=nDWRN4Zc8ymS/BjGlySoOEyyMKDtptuloApunwxHZTdcCkjQgHVndECfgOu4Cyxvdj8VuUNl/6qBMxRZLdpFJzoLBmuOXDuhqmQpFzWNq4/uc1uojR1KKAO7vaxuRXLN1gzp+7w270Bl787AumX+NSuhqSUGIT6Z19P8TiM+Zls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716838596; c=relaxed/simple; bh=hBztDfsju7jvSHs2X1CbqXJ/9RFgcXepl00UZcxNhpE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=gB5GlCO3+c3FxHj/+zzlNG8dfILY64mJ+xlqjOjQNB768+8ZyNKcG7eeiU/Ta1+OpVKdyPV8W+84riD5bfKEXx8TD3vLWR3bhvSy+xv6s21eFUtxwvulVgx/BADeKEwWbwUN5RK0KdvleIAKIvYUa6ROc/E9+CaN5nP1c9G92/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=e4xleDS6; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="e4xleDS6" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2e724bc46c4so323951fa.2 for ; Mon, 27 May 2024 12:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1716838593; x=1717443393; darn=vger.kernel.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=460uV27lQordnsc0AJG+gZtSNZZpMZFmTeFH7GJ2IBs=; b=e4xleDS6EG0oMlnL6PmBruyD0LaoAb459sRhAlFi2ibiZ5JPYDKF3FxwEPryode+z5 MafddPavtJkECGK6LuZU7pNs2d88ZZ7bqvCl3ki71MgVYnqbaqgBBZMlnEHWKGAkaFTl cp1UD0KDnVGd3QX8AR+0z9kh+oDKEMtg8BgtmeNnSUM7+0EBgBric6pnAq4H04dM5Mwm m+fU/YkiKRzyFl6fyfpUhJQuUECKqDmx5QPAYfwbrtl2+KWdGje1WnJWzg7DPh7zFdRY bpBu4Ir9gDMevfvpwd2rpUYELSjCEx+aQEpF7kVnNOY+5/ZNu8t6MLxbIj6/h5tt4nER etNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716838593; x=1717443393; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=460uV27lQordnsc0AJG+gZtSNZZpMZFmTeFH7GJ2IBs=; b=uDHRZvVugVtm/cCR2gZFY4Nqpe4/4DQ4jE8/rMDmPVzW6O+oEwrTu1SYxSj0SoPa7g fTS0WU+4TvCOwycCxC0+TOfp8VKaYvPb1tukloeKF6Q3ngjwU1U4tnv2AH0VH1NeXLnQ O5F+fM30nFr/xhE5P5V4JipANdnOpLTf+sG7JP8C700HuWkb9l1HD6kSt4UsJ3XBOjdd RdTorUg2naAAb89qhCLcyAcR3VVAienFqcTMfQeubfS9KafyDd8hwzhiTD4Bh2RxJ+Rl 64gJXqby+wKFpaYF4rowwWnAiux0sjzxpCjVKZ2Tj3IclqY44DbaQnTZz8K1uM6Qo5q+ h4xQ== X-Forwarded-Encrypted: i=1; AJvYcCV3OLRLvgrftWjv1OIUlRyzLnvIG/iP1vuTMkrj17E5XITWrdcqhCqgVm1kwW9TITHkByruvnhQehNF82SBANSJkCJq X-Gm-Message-State: AOJu0Yynpvm1TvKb+AXJAzuaeMQ8py/mElNhAyQCPDKYxc9m221GTKKh a5fOE6tQMEuzqe42Mq5xFQZYvw7P6sOjgO+7OIJS4mJhEV/9AYJKnQD4qsQ7sLY= X-Google-Smtp-Source: AGHT+IEojifswV/dPUHHhC/U3xFxhX87rNTI4M2ybuWgK1NozFiNdYtCGW3FO7XEsv5sFQh1P0K/Pw== X-Received: by 2002:a2e:9e9a:0:b0:2e1:5644:24e7 with SMTP id 38308e7fff4ca-2e95b1cbdd2mr60399711fa.13.1716838592717; Mon, 27 May 2024 12:36:32 -0700 (PDT) Received: from cloudflare.com ([2a09:bac5:5063:2387::38a:20]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57967499969sm3641328a12.22.2024.05.27.12.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 12:36:32 -0700 (PDT) From: Jakub Sitnicki To: John Fastabend Cc: Geliang Tang , Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Geliang Tang , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH bpf-next 3/8] selftests/bpf: Use bpf_link attachments in test_sockmap In-Reply-To: <6654beff96840_23de2086e@john.notmuch> (John Fastabend's message of "Mon, 27 May 2024 10:12:31 -0700") References: <32cf8376a810e2e9c719f8e4cfb97132ed2d1f9c.1716446893.git.tanggeliang@kylinos.cn> <6654beff96840_23de2086e@john.notmuch> User-Agent: mu4e 1.12.4; emacs 29.1 Date: Mon, 27 May 2024 21:36:31 +0200 Message-ID: <87wmnfujwg.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, May 27, 2024 at 10:12 AM -07, John Fastabend wrote: > Geliang Tang wrote: >> From: Geliang Tang >> >> Switch attachments to bpf_link using bpf_program__attach_sockmap() instead >> of bpf_prog_attach(). > > Sorry it took me a few days to get to this. > > Is there a reason to push this to links vs just leave it as is? I had > a plan to port all the test_sockmap tests into prog_tests anyways. I'll > try to push some initial patch next week. > > The one advantage of test_sockmap is we can have it run for longer > runs by pushing different options through so might be worth keeping > just for that. > > If you really want links here I'm OK with that I guess just asking. It was me who suggested the switch to bpf_link in reaction to a series of cleanups to prog_type and prog_attach_type submitted by Geliang. Relevant threads: https://lore.kernel.org/bpf/9c10d9f974f07fcb354a43a8eca67acb2fafc587.1715926605.git.tanggeliang@kylinos.cn https://lore.kernel.org/bpf/20240522080936.2475833-1-jakub@cloudflare.com https://lore.kernel.org/bpf/e27d7d0c1e0e79b0acd22ac6ad5d8f9f00225303.1716372485.git.tanggeliang@kylinos.cn I thought bpf_links added more value than cleaning up "old style" attachments.