From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2EE2C433FE for ; Mon, 8 Nov 2021 10:10:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA99761181 for ; Mon, 8 Nov 2021 10:10:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235417AbhKHKN3 (ORCPT ); Mon, 8 Nov 2021 05:13:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235650AbhKHKN1 (ORCPT ); Mon, 8 Nov 2021 05:13:27 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57210C061570 for ; Mon, 8 Nov 2021 02:10:42 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id d12so31346004lfv.6 for ; Mon, 08 Nov 2021 02:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=oqR92U7kLA3UxeOztQYj8+Q9vHwXz7gRmE4C5RHEVkw=; b=mxSPnmWnhIzVbpu4Ft0gau7C8lo7e14gLbZZjlTI30TkmBjsi138XoHG0tC02+eLdO WUha1StV1CRlp0dZRtATZueP2VOZSEjuDi5DZq5lY3qoFoYFstKY09IANCwitnxnBD6k tTdGS5n70gKOPnuDOS4Ji0cHKO6j8sAd7o6Ro= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=oqR92U7kLA3UxeOztQYj8+Q9vHwXz7gRmE4C5RHEVkw=; b=zHlwCpHVKek8+14NI0oPYtvKYeEPuMFgAPbvC7SBEygZ1iPFvFcmnZkyAchbMQDzKm 5yfRTIcGBxWYfHjLrwd7BF2nljpYh/MndXHUlcR5zsrSpFTbiiFwhFGgVuAOC6W0WOPu jW8DxibmG++Mkf7M43n2u3Cp/0aRaGTXX5Q5Wl0wUB187x9fMAZLS0zSwpu9aUf602Vv Opn8kd2aR89NPam3JE5WPJb1ZWiZ1i/yt40LYLlx67+2wlzxWUmtty7gu0PW6UwXt++f JvCaX/IV12RjnMz3nIoBCRP/dbJxcCch3Pftzp3B3HFE24AVOYLL76DXpJihUNFdGaF+ jmBg== X-Gm-Message-State: AOAM53136pawnqVicAgP4plgCy8HnMhad6XQsTchCGljT7wO38/JDnmF rMTmjJFoZ9A0lc7Bl4w1+PLzSw== X-Google-Smtp-Source: ABdhPJzsWSqsMKJQeuYHlBx6wPXCvhdJqXjKVtUJFoIyDwCH1f283lPLx5HQfQsGooUBetltFdVo9A== X-Received: by 2002:a05:6512:3c93:: with SMTP id h19mr70746417lfv.411.1636366240713; Mon, 08 Nov 2021 02:10:40 -0800 (PST) Received: from cloudflare.com ([2a01:110f:480d:6f00:ff34:bf12:ef2:5071]) by smtp.gmail.com with ESMTPSA id m15sm483600lfp.9.2021.11.08.02.10.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 02:10:40 -0800 (PST) References: <20211103204736.248403-1-john.fastabend@gmail.com> <20211103204736.248403-2-john.fastabend@gmail.com> User-agent: mu4e 1.1.0; emacs 27.2 From: Jakub Sitnicki To: John Fastabend Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, daniel@iogearbox.net, joamaki@gmail.com, xiyou.wangcong@gmail.com Subject: Re: [PATCH bpf v2 1/5] bpf, sockmap: Use stricter sk state checks in sk_lookup_assign In-reply-to: <20211103204736.248403-2-john.fastabend@gmail.com> Date: Mon, 08 Nov 2021 11:10:39 +0100 Message-ID: <87wnljgdpc.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Nov 03, 2021 at 09:47 PM CET, John Fastabend wrote: > In order to fix an issue with sockets in TCP sockmap redirect cases > we plan to allow CLOSE state sockets to exist in the sockmap. However, > the check in bpf_sk_lookup_assign currently only invalidates sockets > in the TCP_ESTABLISHED case relying on the checks on sockmap insert > to ensure we never SOCK_CLOSE state sockets in the map. > > To prepare for this change we flip the logic in bpf_sk_lookup_assign() > to explicitly test for the accepted cases. Namely, a tcp socket in > TCP_LISTEN or a udp socket in TCP_CLOSE state. This also makes the > code more resilent to future changes. > > Suggested-by: Jakub Sitnicki > Signed-off-by: John Fastabend > --- Thanks, John, for patching up the helper. I will follow up with a test to cover unbound sockets. Reviewed-by: Jakub Sitnicki