From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FB8C433E2 for ; Fri, 11 Sep 2020 11:01:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82FFF221EE for ; Fri, 11 Sep 2020 11:01:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ShknHyn/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725793AbgIKLB5 (ORCPT ); Fri, 11 Sep 2020 07:01:57 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:42438 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725789AbgIKLBt (ORCPT ); Fri, 11 Sep 2020 07:01:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599822098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eEzg2T0c6enr/eWGZnxHCUp3/oydi5RSuwjrdD/cA9U=; b=ShknHyn/mL2L6p9GeG6+bowAvlx7P4qNgWuiNYrUSq9hk6FJjO8+XYqfJ4CNJjvY552Jhx Id9ZWhtpHcVaLkoKzeGIoymnkJir2Vn0pAXmycplieR+s90pIfE0Ofihiak3iVh5JvEDr4 N/f8JUc2HMDQMtZSk0biShGXn1rdVQQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439-uzomnJHXOpC4wvLz-sOhPg-1; Fri, 11 Sep 2020 07:01:36 -0400 X-MC-Unique: uzomnJHXOpC4wvLz-sOhPg-1 Received: by mail-wr1-f69.google.com with SMTP id a12so3382740wrg.13 for ; Fri, 11 Sep 2020 04:01:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=eEzg2T0c6enr/eWGZnxHCUp3/oydi5RSuwjrdD/cA9U=; b=pv71Xfwv9k+MN/PJQcbHpvrxcZd7vc+DoXBLry9cTQLc2XFXjvtDl+hdjwEn2N/Cy4 8yf2QEHwawdrwH8m2npJTVA4mnEhW2Snp1dJ9sVUfXDiwjJaPNdFv/u/2d3EHxfexlnL xXliYMeD3umD4CMCiM2TW48+sj9u6upgjpXTYXe1y3UZ+c7TCJdI+HTYXxvurRZqPqH0 IRoK+w50QYwFv4IdygQ3ZO9TYbmpHI5+nd3IvFIxC6gYPJr0fx7T6Xhg9WUkTeGcGKbI o1HLxIVlroDqVehjw8Xs/UdQcrVSQJ28Gqng2QAFqQZXdreV3SXA+MJc2hqT2G7TrRlw zrJA== X-Gm-Message-State: AOAM533nooyw/rQy8YZVkNRoNmCtMcFQJpxKBtBdKJLMgOZc11ndSBp7 hnoyjN35BkGMFcgNnIV5mVFB++w1/H63mTS0HOQv0351nhuon404uPGuL3ycpWpXvmjDmYI4fGH Z0gboDQgD0wsl X-Received: by 2002:a1c:6145:: with SMTP id v66mr1720656wmb.171.1599822095379; Fri, 11 Sep 2020 04:01:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM3BfHNcabpmdvBOcrAOlm2aEokm0JjvlMdTUnLbUCGivJ2Ze6uZUWd/xwu3k9WAnNKPdp5g== X-Received: by 2002:a1c:6145:: with SMTP id v66mr1720625wmb.171.1599822095142; Fri, 11 Sep 2020 04:01:35 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id m4sm4066786wro.18.2020.09.11.04.01.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 04:01:34 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id AC65E1829D4; Fri, 11 Sep 2020 13:01:33 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Andrii Nakryiko , Jiri Olsa Cc: Alexei Starovoitov , Daniel Borkmann , Networking , bpf , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Jesper Dangaard Brouer , Eelco Chaudron Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Adding test for arg dereference in extension trace In-Reply-To: References: <20200909151115.1559418-1-jolsa@kernel.org> <20200909151115.1559418-2-jolsa@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 11 Sep 2020 13:01:33 +0200 Message-ID: <87y2lga86q.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Andrii Nakryiko writes: > On Wed, Sep 9, 2020 at 8:38 AM Jiri Olsa wrote: >> >> Adding test that setup following program: >> >> SEC("classifier/test_pkt_md_access") >> int test_pkt_md_access(struct __sk_buff *skb) >> >> with its extension: >> >> SEC("freplace/test_pkt_md_access") >> int test_pkt_md_access_new(struct __sk_buff *skb) >> >> and tracing that extension with: >> >> SEC("fentry/test_pkt_md_access_new") >> int BPF_PROG(fentry, struct sk_buff *skb) >> >> The test verifies that the tracing program can >> dereference skb argument properly. >> >> Signed-off-by: Jiri Olsa Just FYI, I included this same patch in my freplace series. I didn't change anything in the version I just resent, but I'll work with Jiri and get an updated version of this into the next version based on your comments here... :) -Toke