BPF List
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Ihor Solodrai <ihor.solodrai@linux.dev>
Cc: andrii@kernel.org,  ast@kernel.org,  daniel@iogearbox.net,
	bpf@vger.kernel.org,  mykolal@fb.com,  kernel-team@meta.com
Subject: Re: [PATCH bpf-next] kbuild, bpf: enable --btf_features=attributes
Date: Tue, 15 Apr 2025 00:58:43 -0700	[thread overview]
Message-ID: <87zfgh26vg.fsf@gmail.com> (raw)
In-Reply-To: <20250414185918.538195-1-ihor.solodrai@linux.dev> (Ihor Solodrai's message of "Mon, 14 Apr 2025 11:59:18 -0700")

Ihor Solodrai <ihor.solodrai@linux.dev> writes:

> pahole v1.30 has a BTF encoding feature for arbitrary attributes, used
> in particular for tagging bpf_arena_alloc_pages and
> bpf_arena_free_pages BPF kfuncs [1][2].
>
> Enable it for the kernel build.
>
> [1] https://lore.kernel.org/bpf/20250130201239.1429648-1-ihor.solodrai@linux.dev/
> [2] https://lore.kernel.org/bpf/20250228194654.1022535-1-ihor.solodrai@linux.dev/
>
> Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
> ---

With this patch and a new pahole I see the following text in vmlinux.h:

  ...
  extern void __attribute__((address_space(1))) *bpf_arena_alloc_pages(void *p__map, void __attribute__((address_space(1))) *addr__ign, u32 page_cnt, int node_id, u64 flags) __weak __ksym;
  extern void bpf_arena_free_pages(void *p__map, void __attribute__((address_space(1))) *ptr__ign, u32 page_cnt) __weak __ksym;
  ...

test_progs are compiling and passing w/o issues.

Tested-by: Eduard Zingerman <eddyz87@gmail.com>

[...]

  reply	other threads:[~2025-04-15  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 18:59 [PATCH bpf-next] kbuild, bpf: enable --btf_features=attributes Ihor Solodrai
2025-04-15  7:58 ` Eduard Zingerman [this message]
2025-04-15 18:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfgh26vg.fsf@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=ihor.solodrai@linux.dev \
    --cc=kernel-team@meta.com \
    --cc=mykolal@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox