From: Yonghong Song <yonghong.song@linux.dev>
To: Oleg Nesterov <oleg@redhat.com>, Yonghong Song <yhs@fb.com>,
Kui-Feng Lee <kuifeng@fb.com>,
Andrii Nakryiko <andrii@kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Martin KaFai Lau <martin.lau@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf: task_group_seq_get_next: cleanup the usage of get/put_task_struct
Date: Mon, 21 Aug 2023 18:06:47 -0700 [thread overview]
Message-ID: <88ba3052-9e09-af0d-347e-2a8e8b043617@linux.dev> (raw)
In-Reply-To: <20230821200311.GA22497@redhat.com>
On 8/21/23 1:03 PM, Oleg Nesterov wrote:
> get_pid_task() makes no sense, the code does put_task_struct() soon after.
> Use find_task_by_pid_ns() instead of find_pid_ns + get_pid_task and kill
> kill put_task_struct(), this allows to do get_task_struct() only once
remove the duplicated 'kill' in the above.
> before return.
>
> While at it, kill the unnecessary "if (!pid)" check in the "if (!*tid)"
> block, this matches the next usage of find_pid_ns() + get_pid_task() in
> this function.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
LGTM.
Acked-by: Yonghong Song <yonghong.song@linux.dev>
next prev parent reply other threads:[~2023-08-22 1:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 15:09 [PATCH] bpf: task_group_seq_get_next: cleanup the usage of next_thread() Oleg Nesterov
2023-08-21 17:55 ` Kui-Feng Lee
2023-08-21 18:34 ` Oleg Nesterov
2023-08-21 19:54 ` Oleg Nesterov
2023-08-21 20:24 ` Kui-Feng Lee
2023-08-21 20:03 ` [PATCH] bpf: task_group_seq_get_next: cleanup the usage of get/put_task_struct Oleg Nesterov
2023-08-21 20:32 ` Kui-Feng Lee
2023-08-21 20:38 ` Kui-Feng Lee
2023-08-22 1:06 ` Yonghong Song [this message]
2023-08-22 12:05 ` Oleg Nesterov
2023-08-22 12:05 ` [PATCH V2] " Oleg Nesterov
2023-08-25 14:28 ` Daniel Borkmann
2023-08-25 16:26 ` Oleg Nesterov
2023-08-25 12:41 ` [PATCH] bpf: task_group_seq_get_next: cleanup the usage of next_thread() Oleg Nesterov
2023-08-25 13:36 ` Eric W. Biederman
2023-08-25 13:50 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88ba3052-9e09-af0d-347e-2a8e8b043617@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=kuifeng@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=oleg@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox