From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16850306B11 for ; Wed, 12 Nov 2025 11:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762947037; cv=none; b=p223P6o/aYwooK1b4S03t8J5HrKeiZqrVoyx1xeGmFAXIuZTjxlFIPNtZ14l7f1TQTeS2lswUnwTqL9TH8ny57s1QzGgt4RTfwqrZNwh0hfMt7MTxNKvOd27+qs/oiWqvRJ/QDt0TnSIRXjPyKROUlPKYcwA3d39zuADV2AkXMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762947037; c=relaxed/simple; bh=iTAh58xsSTK/DPrCrA9XXO9oOUT/gyUSwdPtMZDZRY4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=STvXr1VDi7jlEm6VGs2IA7ttLxO6l2P02kUu7I4TCLOEbufUrPwEGAi4ynqwuIM4YKdbQdNu8glS4yrq6YYl4YIbKMdAGXIVF/KE5hzZ9SlgYvGn5D9FGBTJsOBVXMmPhNQ9PQYgL4JPy8km1Q4pQOHE4BkkOMeErWHKR6lY8LU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BjVdOQYk; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BjVdOQYk" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47778704516so3659685e9.3 for ; Wed, 12 Nov 2025 03:30:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762947034; x=1763551834; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l/oUH46h86/olGMZU+XghYpDhfAZ96DwWr356lECM4A=; b=BjVdOQYkNn1GugyEtpXSuZbkJ+6NMebvOiOl+vQATSk4DKzy9dP0IzIfF7t7DTxIc0 h79Cayo4rd1tZHnm3UF6iP16NquA/XmQD1sqR08B0brtBRUm4ITnOXvc+1xwtwV2k7jX IqISyf0r5iDNq2JTyIpuefvmlX6xXMDkd9TrEWPtwqTgWsn4oyqRRTyIYNo4RHtFR6mP 09DYULt2CWaTGcv8PemxgkCUZjwV0kIiNzt5YSy402YM+Flyd34wvMhjIH7WNREJLZoB 3ZNkEHdsDRfFf3C6aBNo8t5pZGT8AXJXDZZepxyvwuUsqBbgn11CFPp+iptlcxfzy8jr FszA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762947034; x=1763551834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l/oUH46h86/olGMZU+XghYpDhfAZ96DwWr356lECM4A=; b=ep3sJjqw2oEO/t0IwSLAweG/fzokFgeMmWYIfQwuHJSqLNlsVGN0X/kOAsJBgj0UMU 0JxeX4K3BBBDxtP+JCyvWTGdCrheDVzvlyKFW6fUIB2yIZaZjbEKGVSCqBZ3On+Lnu/i RFHFlRG/qYCd3Lz7c0br+/qMfLTpsFD8LfjOvHB1i1tfxj7MJBd8I8oNaCMHNXJ61DK0 7EdCnrb0ThRY+KVs8U6my20ruQtl1QNzNOitpdNZWxqnfgw383m6hgepiqG9dCDN4Zz2 bYL9mBxyuWAgkPqVmF/YKleQzrq0dzQ9+6zwrFusO5KpvX7KSjwTHqrRAJ3rflDl3afj gxjg== X-Forwarded-Encrypted: i=1; AJvYcCVczfHOz5T4IWX9V6xuTuKrJ7x8Eo59PJgG7g1ffphdQfvmuZtmlOxOX8yF0i/4COLvizY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2By2hPzvt2XdwodcFQnZNvO4EuuG2dOoFByA1XkvbwfUD+ZP8 /SOaxn9Ot3s+OABSssIu3m7WsEBaNDt4nQ4JwY/tYCdO9WJBsuQXlsfZ X-Gm-Gg: ASbGncv0JWr9qg84mWz/bsWACUN5CqB0dAk/E7gU5zhQUtUeJ6vQY882dhQ4NG1oaZo dp/ODTk4fTKBqTTr77SPsZWWBCVf6UX1vvCEcG9GxQDBODzL4fHTEtUruMfty4+AciFDEBpFOjR QO07g9TA06JtBdQgibRy9twCu0PzDSo4HALGOtA83SeaofbIylM2cVIo1cdnFCQnzpsqAz72Jfu wkOGQv3FKW8CuWFjiDdTvkeevbUuC5ft9l1kLZXJZYmOJhdBUBIpkeyPryO0/K33Bkc+9BjTK7b lQSF/j5JE2QZPdq4Mx1IymGA0mL9sv2/mGwBKftDvFm1T9TWT7UdtqhvBeXUb8cunkRUJeDN6ms pS1Ua2Syyjp3iMXl82F+odbR01kXo4gTCbzIRkJ9gQ0bckqQg430WwzcGadfH8BvnZmvyZ5y6/V kfJm6jurFr3LwxSkTgIH7rx2A= X-Google-Smtp-Source: AGHT+IFzZn82+HqmV7Z5oaduLfvBaDy2CYnyKKDWs/rhY5yLhynN3LzPM9CdU2cQ0vUhoC+2FQjWgA== X-Received: by 2002:a05:600c:4f93:b0:477:bcb:24cd with SMTP id 5b1f17b1804b1-47787095d98mr24817395e9.22.1762947034215; Wed, 12 Nov 2025 03:30:34 -0800 (PST) Received: from [10.125.200.88] ([165.85.126.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e2ad4csm31122115e9.1.2025.11.12.03.30.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Nov 2025 03:30:33 -0800 (PST) Message-ID: <89e33ec4-051d-4ca5-8fcd-f500362dee91@gmail.com> Date: Wed, 12 Nov 2025 13:30:32 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 0/6] net/mlx5e: Speedup channel configuration operations To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Tariq Toukan , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" Cc: Saeed Mahameed , Leon Romanovsky , Mark Bloch , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Gal Pressman , Leon Romanovsky , Moshe Shemesh , William Tu , Dragos Tatulea , Nimrod Oren , Alex Lazar References: <1762939749-1165658-1-git-send-email-tariqt@nvidia.com> <874iqzldvq.fsf@toke.dk> Content-Language: en-US From: Tariq Toukan In-Reply-To: <874iqzldvq.fsf@toke.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/11/2025 12:54, Toke Høiland-Jørgensen wrote: > Tariq Toukan writes: > >> Hi, >> >> This series significantly improves the latency of channel configuration >> operations, like interface up (create channels), interface down (destroy >> channels), and channels reconfiguration (create new set, destroy old >> one). > > On the topic of improving ifup/ifdown times, I noticed at some point > that mlx5 will call synchronize_net() once for every queue when they are > deactivated (in mlx5e_deactivate_txqsq()). Have you considered changing > that to amortise the sync latency over the full interface bringdown? :) > > -Toke > > Correct! This can be improved and I actually have WIP patches for this, as I'm revisiting this code area recently.