From: Kui-Feng Lee <sinquersw@gmail.com>
To: Yuran Pereira <yuran.pereira@hotmail.com>,
bpf@vger.kernel.org, yonghong.song@linux.dev
Cc: shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net,
song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org,
sdf@google.com, haoluo@google.com, jolsa@kernel.org,
mykolal@fb.com, brauner@kernel.org, iii@linux.ibm.com,
kuifeng@meta.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 2/2] selftests/bpf: Add malloc failure checks in bpf_iter
Date: Wed, 25 Oct 2023 21:40:02 -0700 [thread overview]
Message-ID: <8a14c779-441d-424c-b1f4-fdc7c5ce407e@gmail.com> (raw)
In-Reply-To: <DB3PR10MB6835A2CBEE0EBE31D07FABFAE8DDA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM>
Good job! LGTM
Acked-by: Kui-Feng Lee <thinker.li@gmail.com>
On 10/25/23 19:03, Yuran Pereira wrote:
> Since some malloc calls in bpf_iter may at times fail,
> this patch adds the appropriate fail checks, and ensures that
> any previously allocated resource is appropriately destroyed
> before returning the function.
>
> Signed-off-by: Yuran Pereira <yuran.pereira@hotmail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
> index 7db6972ed952..955d374ba656 100644
> --- a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
> +++ b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
> @@ -698,7 +698,7 @@ static void test_overflow(bool test_e2big_overflow, bool ret1)
> goto free_link;
>
> buf = malloc(expected_read_len);
> - if (!buf)
> + if (!ASSERT_OK_PTR(buf, "malloc"))
> goto close_iter;
>
> /* do read */
> @@ -869,6 +869,8 @@ static void test_bpf_percpu_hash_map(void)
>
> skel->rodata->num_cpus = bpf_num_possible_cpus();
> val = malloc(8 * bpf_num_possible_cpus());
> + if (!ASSERT_OK_PTR(val, "malloc"))
> + goto out;
>
> err = bpf_iter_bpf_percpu_hash_map__load(skel);
> if (!ASSERT_OK_PTR(skel, "bpf_iter_bpf_percpu_hash_map__load"))
> @@ -1046,6 +1048,8 @@ static void test_bpf_percpu_array_map(void)
>
> skel->rodata->num_cpus = bpf_num_possible_cpus();
> val = malloc(8 * bpf_num_possible_cpus());
> + if (!ASSERT_OK_PTR(val, "malloc"))
> + goto out;
>
> err = bpf_iter_bpf_percpu_array_map__load(skel);
> if (!ASSERT_OK_PTR(skel, "bpf_iter_bpf_percpu_array_map__load"))
next prev parent reply other threads:[~2023-10-26 4:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231026020319.1203600-1-yuran.pereira@hotmail.com>
2023-10-26 2:03 ` [PATCH bpf-next v2 1/2] selftests/bpf: Convert CHECK macros to ASSERT_* macros in bpf_iter Yuran Pereira
2023-10-26 4:33 ` Kui-Feng Lee
2023-10-27 4:42 ` Yonghong Song
2023-10-26 2:03 ` [PATCH bpf-next v2 2/2] selftests/bpf: Add malloc failure checks " Yuran Pereira
2023-10-26 4:40 ` Kui-Feng Lee [this message]
2023-10-27 4:37 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a14c779-441d-424c-b1f4-fdc7c5ce407e@gmail.com \
--to=sinquersw@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=iii@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuifeng@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
--cc=yuran.pereira@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox