Re: [PATCH dwarves v2] btf_encoder: fix memory access bugs

[ihor.solodrai@linux.dev]

December 16, 2024 at 10:31 AM, "Ihor Solodrai" <ihor.solodrai@pm.me> wrote:

> 
> When compiled with address sanitizer, a couple of errors were reported
> 
> on pahole BTF encoding:
> 
>  * A memory leak of strdup(func->alias), due to unchecked
> 
>  reassignment.
> 
>  * A read of uninitialized memory in gobuffer__sort or bsearch in
> 
>  case btf_funcs gobuffer is empty.
> 
> Used compiler flags:
> 
>  -fsanitize=undefined,address
> 
>  -fsanitize-recover=address
> 
>  -fno-omit-frame-pointer
> 
> v1: https://lore.kernel.org/dwarves/20241213233205.633927-1-ihor.solodrai@pm.me/
> 
> Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
> 
> Signed-off-by: Ihor Solodrai <ihor.solodrai@pm.me>
> 
> ---
> 
>  btf_encoder.c | 11 +++++++++--
> 
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 

Alan, Arnaldo,

This patch hasn't been applied.
Just a reminder in case it fell off the radar.

Thanks.