BPF List
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
	Geliang Tang <geliang@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Mykola Lysenko <mykolal@fb.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: Geliang Tang <tanggeliang@kylinos.cn>,
	bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config
Date: Wed, 29 May 2024 02:01:06 +0200	[thread overview]
Message-ID: <8c406b8d6cf2347589c1e40f0b87095550306c4a.camel@linux.ibm.com> (raw)
In-Reply-To: <978a90ad-2e4c-ac06-30bf-6449444d47f9@iogearbox.net>

On Fri, 2024-05-24 at 18:27 +0200, Daniel Borkmann wrote:
> On 5/16/24 3:41 AM, Geliang Tang wrote:
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> > 
> > The kconfigs CONFIG_INET_XFRM_TUNNEL and CONFIG_INET6_XFRM_TUNNEL
> > are
> > needed by test_tunnel tests. This patch enables them together with
> > the
> > dependent kconfigs CONFIG_INET_IPCOMP and CONFIG_INET6_IPCOMP.
> > 
> > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> > ---
> >   tools/testing/selftests/bpf/config | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/bpf/config
> > b/tools/testing/selftests/bpf/config
> > index eeabd798bc3a..8aa56e6bdac1 100644
> > --- a/tools/testing/selftests/bpf/config
> > +++ b/tools/testing/selftests/bpf/config
> > @@ -95,3 +95,7 @@ CONFIG_XDP_SOCKETS=y
> >   CONFIG_XFRM_INTERFACE=y
> >   CONFIG_TCP_CONG_DCTCP=y
> >   CONFIG_TCP_CONG_BBR=y
> > +CONFIG_INET_IPCOMP=y
> > +CONFIG_INET_XFRM_TUNNEL=y
> > +CONFIG_INET6_IPCOMP=y
> > +CONFIG_INET6_XFRM_TUNNEL=y
> > 
> 
> [ +Ilya ]
> 
> Looks like this triggers a boot hang on s390x :
> 
> https://github.com/kernel-patches/bpf/actions/runs/9215175853/job/25353574288

Hi,

I could not reproduce this neither with vmtest nor with my own build,
and it doesn't look related.

I'm not exactly sure what could cause d_alloc_parallel() to hang, but
apparently the CI is using a different vmtest script, which uses 9p to
mount root - perhaps there is a deadlock in 9p?

Can someone retrigger the build to see if the issue persists?

Best regards,
Ilya

  reply	other threads:[~2024-05-29  0:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16  1:41 [PATCH bpf-next] selftests/bpf: Enable INET_XFRM_TUNNEL in config Geliang Tang
2024-05-24 16:27 ` Daniel Borkmann
2024-05-29  0:01   ` Ilya Leoshkevich [this message]
2024-06-11  2:12     ` Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c406b8d6cf2347589c1e40f0b87095550306c4a.camel@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=geliang@kernel.org \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=mykolal@fb.com \
    --cc=sdf@google.com \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=tanggeliang@kylinos.cn \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox