From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD053C388F7 for ; Fri, 13 Nov 2020 15:36:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B1F9208D5 for ; Fri, 13 Nov 2020 15:36:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726457AbgKMPdn (ORCPT ); Fri, 13 Nov 2020 10:33:43 -0500 Received: from www62.your-server.de ([213.133.104.62]:56100 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726324AbgKMPdm (ORCPT ); Fri, 13 Nov 2020 10:33:42 -0500 Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1kdb52-0000Z9-KS; Fri, 13 Nov 2020 16:33:40 +0100 Received: from [85.7.101.30] (helo=pc-9.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdb52-000XAi-CI; Fri, 13 Nov 2020 16:33:40 +0100 Subject: Re: [PATCH bpf-next 2/2] bpf: Expose bpf_d_path helper to sleepable LSM hooks To: Yonghong Song , KP Singh , linux-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: Alexei Starovoitov , Martin KaFai Lau , Song Liu , Jann Horn , Hao Luo , Florent Revest , Brendan Jackman References: <20201112171907.373433-1-kpsingh@chromium.org> <20201112171907.373433-2-kpsingh@chromium.org> <63870297-fffe-f01e-9747-219b63c5d7f4@fb.com> From: Daniel Borkmann Message-ID: <8ca075b7-1fda-bd63-e2c2-68618d30b414@iogearbox.net> Date: Fri, 13 Nov 2020 16:33:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <63870297-fffe-f01e-9747-219b63c5d7f4@fb.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.4/25987/Fri Nov 13 14:19:33 2020) Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 11/13/20 4:18 AM, Yonghong Song wrote: > > > On 11/12/20 9:19 AM, KP Singh wrote: >> From: KP Singh >> >> Sleepable hooks are never called from an NMI/interrupt context, so it is >> safe to use the bpf_d_path helper in LSM programs attaching to these >> hooks. >> >> The helper is not restricted to sleepable programs and merely uses the >> list of sleeable hooks as the initial subset of LSM hooks where it can > > sleeable => sleepable > > probably not need to resend if no other major changes. The maintainer > can just fix it up before merging. Did while rebasing & applying, thanks everyone! >> be used. >> >> Signed-off-by: KP Singh > > Acked-by: Yonghong Song