From: Eduard Zingerman <eddyz87@gmail.com>
To: Leon Hwang <hffilwlqm@gmail.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
yonghong.song@linux.dev, kernel-patches-bot@fb.com
Subject: Re: [PATCH v2 bpf-next 0/2] bpf, verifier: Correct tail_call_reachable for bpf prog
Date: Mon, 10 Jun 2024 14:28:03 -0700 [thread overview]
Message-ID: <8d49a2b993e971106d76d85fb18a934b380c0593.camel@gmail.com> (raw)
In-Reply-To: <20240610124224.34673-1-hffilwlqm@gmail.com>
On Mon, 2024-06-10 at 20:42 +0800, Leon Hwang wrote:
> It's confusing to inspect 'prog->aux->tail_call_reachable' with drgn[0],
> when bpf prog has tail call but 'tail_call_reachable' is false.
>
> This patch corrects 'tail_call_reachable' when bpf prog has tail call.
>
> Therefore, it's unnecessary to detect tail call in x86 jit. Let's remove
> it.
>
> Changes:
> v1 -> v2:
> * Address comment from Yonghong:
> * Remove unnecessary tail call detection in x86 jit.
>
> ---
All seems correct.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2024-06-10 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 12:42 [PATCH v2 bpf-next 0/2] bpf, verifier: Correct tail_call_reachable for bpf prog Leon Hwang
2024-06-10 12:42 ` [PATCH v2 bpf-next 1/2] " Leon Hwang
2024-06-10 12:42 ` [PATCH v2 bpf-next 2/2] bpf, x64: Remove tail call detection Leon Hwang
2024-06-10 21:28 ` Eduard Zingerman [this message]
2024-06-21 3:00 ` [PATCH v2 bpf-next 0/2] bpf, verifier: Correct tail_call_reachable for bpf prog patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d49a2b993e971106d76d85fb18a934b380c0593.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hffilwlqm@gmail.com \
--cc=kernel-patches-bot@fb.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox