From: Eduard Zingerman <eddyz87@gmail.com>
To: Amery Hung <ameryhung@gmail.com>, bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, alexei.starovoitov@gmail.com,
andrii@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH bpf v1 2/2] selftests/bpf: Test using cgroup storage in a tail call callee program
Date: Mon, 01 Dec 2025 17:07:59 -0800 [thread overview]
Message-ID: <8da95cbd0f554e3ab62a40116f8fd08201a1d593.camel@gmail.com> (raw)
In-Reply-To: <20251202001822.2769330-2-ameryhung@gmail.com>
On Mon, 2025-12-01 at 16:18 -0800, Amery Hung wrote:
> Check that a BPF program that uses cgroup storage cannot be added to
> a program array map.
>
> Signed-off-by: Amery Hung <ameryhung@gmail.com>
> ---
Hi Amery,
Mabye I'm making some silly systematic mistake, but when I pick this
test w/o picking patch #1 the test still passes.
I'm at ff34657aa72a ("bpf: optimize bpf_map_update_elem() for map-in-map types").
Inserting some printk shows that -EINVAL is propagated for map update
from kernel/bpf/core.c:__bpf_prog_map_compatible() line 2406
(`ret = map->owner->storage_cookie[i] == cookie || !cookie;`).
[...]
next prev parent reply other threads:[~2025-12-02 1:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 0:18 [PATCH bpf v1 1/2] bpf: Disallow tail call to programs that use cgroup storage Amery Hung
2025-12-02 0:18 ` [PATCH bpf v1 2/2] selftests/bpf: Test using cgroup storage in a tail call callee program Amery Hung
2025-12-02 0:35 ` bot+bpf-ci
2025-12-02 1:09 ` Alexei Starovoitov
2025-12-02 1:11 ` Chris Mason
2025-12-02 1:07 ` Eduard Zingerman [this message]
2025-12-02 5:44 ` Amery Hung
2025-12-02 0:35 ` [PATCH bpf v1 1/2] bpf: Disallow tail call to programs that use cgroup storage bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8da95cbd0f554e3ab62a40116f8fd08201a1d593.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox