Re: [PATCH bpf-next 2/3] selftests/bpf: report placeholder tests as SKIP, not OK

[Eduard Zingerman <eddyz87@gmail.com>]

On Fri, 2026-08-21 at 13:13 -0700, Vineet Gupta wrote:
> Several verifier test files wrap their contents in a feature gate and provide
> a one-line placeholder program in the #else arm, so the file still yields
> something when the toolchain or JIT cannot support the tested instructions.
> 
> However the placeholder is annotated __success, so it reports as a pass,
> whereas this is really a SKIP.
> 
> >  #318/1   verifier_ldsx/cpuv4 is not supported by compiler or jit, ...:OK
> >  #318     verifier_ldsx:OK
> 
> This causes skipped coverage to be overlooked: see the next patch where
> BPF_GCC builds miss a whole bunch of test due to clang only gate.
> 
> Add a __skip("reason") annotation for a compile-time gate, and use it for the
> placeholders.
> 
> After this change, above tests reported as
> 
> >  #318/1   verifier_ldsx/cpuv4 is not supported by compiler or jit, ...:SKIP
> >  #318     verifier_ldsx:SKIP
> 
> Signed-off-by: Vineet Gupta <vineet.gupta@linux.dev>
> ---

Neat feature, thanks!

Acked-by: Eduard Zingerman <eddyz87@gmail.com>

...