From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 061BB16428 for ; Tue, 2 Jan 2024 21:06:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WbwZxhPe" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a285d66a79eso88610666b.1 for ; Tue, 02 Jan 2024 13:06:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704229585; x=1704834385; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=U0KXHZ06k9S2EX+ZCQ4gLcT3OzUpEKdfZn7xkLRozQQ=; b=WbwZxhPe08Y0bE+grDRQQ9hKhrGHWIID8a+8QejRirCEwNUNDXT6DJ3QPdkeFRWfa5 nCEfakXZEdijgkiVR3et8yKG0bVM8WDNFw7+qHm2kqJuaoTcULLf4MwyZWknIdvRj54p QIyOkDDjB3oAQDg47qKhgifaA6DHwLv2rQmEZmMQ1vS4uFpHgPetbLQfe2Q9E+llWaKK Bz24v0TXI+t3wpBb97rcaeNcFtjQE/BEEdOTEIB31MD5ORCI8eTGQcgPYGzP+zThwOBa HEMJmJMTQbo48m1UOjDaMGjSosjSvjmzyqp/+Kmf++Lf+JzJZZCzqMwUlpKB8Xe41rXC jJPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704229585; x=1704834385; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U0KXHZ06k9S2EX+ZCQ4gLcT3OzUpEKdfZn7xkLRozQQ=; b=uFz1vekRgAG4O6E4CXz5PCh1aIR/FHe3KwNRG7wyMA++dDociMuF08AsyRK9zYdZf0 ThfXx+Ubx2G+PhQJMdBphKP5CoXv26zI8l7HmqNZ7bH7aQPSp6YwzbrWWYrk62r2LBk1 3/m+HCBIbMrI1zHX3EZJK1CwSnKTUbzZWZQ3U0VHtfdB85QSFmMOJyWDaJkq9wpDA8Bv fEgXSulrln+36CYjJYnY8ynqZrWPO8IA3qopCDZ4ci89yPTJVzEloxECT6fmYN/7hJ70 bAsfmZh1PqRAQtqxnRL9ZQ0CXVXUngNro7VA5uisiFuCQINM/YLxoDxdyo536DijtFBF cNgQ== X-Gm-Message-State: AOJu0YzoOtmHZqmVyknU6IkNRwJn9KOEtB+8KFAliq3kGE5iSwhlg0Na o0x+bh7ZO3i8nrsRiL9fZEY= X-Google-Smtp-Source: AGHT+IHUj2Blu3z9TOY1rfE9nwQ1ZKvnsI0oPIu9892tAtCvgK5ocIOogAlIlbnJtMyFpLm2SsqMYw== X-Received: by 2002:a17:906:25d8:b0:a23:69ea:659e with SMTP id n24-20020a17090625d800b00a2369ea659emr8411052ejb.136.1704229584926; Tue, 02 Jan 2024 13:06:24 -0800 (PST) Received: from [192.168.1.95] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id ef5-20020a17090697c500b00a269597d173sm12139714ejb.135.2024.01.02.13.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 13:06:22 -0800 (PST) Message-ID: <90e7216beb252319145d24a805a06355cb4935a2.camel@gmail.com> Subject: Re: [PATCH bpf-next] bpf: Track aligned st store as imprecise spilled registers From: Eduard Zingerman To: Yonghong Song , bpf@vger.kernel.org Cc: Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , kernel-team@fb.com, Martin KaFai Lau , Kuniyuki Iwashima , Martin KaFai Lau Date: Tue, 02 Jan 2024 23:06:20 +0200 In-Reply-To: <20240102190726.2017424-1-yonghong.song@linux.dev> References: <20240102190726.2017424-1-yonghong.song@linux.dev> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWWA+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2024-01-02 at 11:07 -0800, Yonghong Song wrote: > With patch set [1], precision backtracing supports register spill/fill > to/from the stack. The patch [2] allows initial imprecise register spill > with content 0. This is a common case for cpuv3 and lower for > initializing the stack variables with pattern > r1 =3D 0 > *(u64 *)(r10 - 8) =3D r1 > and the [2] has demonstrated good verification improvement. >=20 > For cpuv4, the initialization could be > *(u64 *)(r10 - 8) =3D 0 > The current verifier marks the r10-8 contents with STACK_ZERO. > Similar to [2], let us permit the above insn to behave like > imprecise register spill which can reduce number of verified states. >=20 > I checked cpuv3 and cpuv4 with and without this patch. > There is no change for cpuv3 since '*(u64 *)(r10 - 8) =3D 0' > is only generated with cpuv4. > [...] >=20 > test_l4lb_noinline and test_l4lb_noinline_dynptr has minor regression, bu= t > pyperf600_bpf_loop and local_storage_bench gets pretty good improvement. >=20 > [1] https://lore.kernel.org/all/20231205184248.1502704-1-andrii@kernel.= org/ > [2] https://lore.kernel.org/all/20231205184248.1502704-9-andrii@kernel.= org/ >=20 > Cc: Kuniyuki Iwashima > Cc: Martin KaFai Lau > Signed-off-by: Yonghong Song Acked-by: Eduard Zingerman