Re: [PATCH bpf-next v3 2/4] bpf: Verifier support for sleepable raw tracepoint programs

[Leon Hwang <leon.hwang@linux.dev>]

On 12/3/26 14:21, Menglong Dong wrote:
> On 2026/3/12 13:50 Leon Hwang <leon.hwang@linux.dev> write:
>> On 12/3/26 07:07, Kumar Kartikeya Dwivedi wrote:
>>> On Wed, 11 Mar 2026 at 19:53, <bot+bpf-ci@kernel.org> wrote:

[...]

>>>
>>> We can ignore AI for now, Leon has a change for this.
>>>
>> Just to confirm the change: is it
>> https://lore.kernel.org/bpf/20260303150639.85007-2-leon.hwang@linux.dev/?
>>
>> If yes, it is to add "fsession" to the verbose log message in
>> check_get_func_ip(). Then, the AI review is correct: "fsession" was
>> missing here.
>>
>> After searching for "fexit" in verifier.c, "FENTRY/FEXIT" can be updated
>> to "FENTRY/FEXIT/FSESSION" in bpf_check_attach_target(), and "fsession"
>> is missing in some comments. I'm not sure whether it is worth a patch to
>> do such cleanup work.
> 
> Ah, when I search the "fentry.*fexit", I found that there do have
> some missed things in:
> - the comments
> - the log message in check_get_func_ip() and check_attach_btf_id()
> - the document in bpftool-prog.rst
> - the help info in bpftool
> - bash-completion of bpftool
> 
> I can send a series to fix these things, except the log message in
> check_get_func_ip(), which is already in Leon's patch.
> 

More appropriate to include it in your series, I think.

Thanks,
Leon