From: Felix Maurer <fmaurer@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org, andrii@kernel.org, mykolal@fb.com,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org
Subject: Re: [PATCH bpf-next] selftests: bpf: Use BTF map in sk_assign
Date: Tue, 7 Feb 2023 12:25:23 +0100 [thread overview]
Message-ID: <92d425d4-e366-adb4-c7ed-97d74a7b9f16@redhat.com> (raw)
In-Reply-To: <CAEf4BzZ565hQLAhHixb9pDWtS9CD72u5-rswxN-vwj-BPXKQ-Q@mail.gmail.com>
On 06.02.23 23:58, Andrii Nakryiko wrote:
> On Mon, Feb 6, 2023 at 8:07 AM Felix Maurer <fmaurer@redhat.com> wrote:
>>
>> The sk_assign selftest uses tc to load the BPF object file for the test. If
>> tc is linked against libbpf 1.0+, this test failed, because the BPF file
>> used the legacy maps section. This approach is considered legacy by libbpf
>> and tc (see examples/bpf/README in the iproute2 repo).
>>
>> Therefore, switch to the approach recommended by iproute2 and use a BTF
>> defined map. This is also well supported by libbpf.
>>
>> Signed-off-by: Felix Maurer <fmaurer@redhat.com>
>> ---
>
> This test was updated (see [0]) to support iproute2 version with and
> without libbpf support. Please check the latest bpf-next/master.
>
> [0] 7ce878ca81bc ("selftests/bpf: Fix sk_assign on s390x")
Sorry for the noise, I missed that commit. Forget about my patch then.
Felix
prev parent reply other threads:[~2023-02-07 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 16:07 [PATCH bpf-next] selftests: bpf: Use BTF map in sk_assign Felix Maurer
2023-02-06 22:58 ` Andrii Nakryiko
2023-02-07 11:25 ` Felix Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92d425d4-e366-adb4-c7ed-97d74a7b9f16@redhat.com \
--to=fmaurer@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox