From: Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
To: Emil Tsalapatis <emil@etsalapatis.com>, bpf@vger.kernel.org
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
eddyz87@gmail.com, etsal@meta.com, ihor.solodrai@linux.dev,
martin.lau@kernel.org, memxor@gmail.com, puranjay@kernel.org,
song@kernel.org, yonghong.song@linux.dev
Subject: Re: [PATCH v2 04/13] selftests: bpf: Make WRITE_ONCE macro in bpf_atomic.h conditional
Date: Tue, 27 Jan 2026 19:26:30 +0000 [thread overview]
Message-ID: <92fcc97e-1313-424e-b67d-d86effda3481@gmail.com> (raw)
In-Reply-To: <20260127181610.86376-5-emil@etsalapatis.com>
On 1/27/26 18:16, Emil Tsalapatis wrote:
> From: Emil Tsalapatis <etsal@meta.com>
>
> The WRITE_ONCE macro is identically defined both in bpf_atomic.h
> and in bpf_arena_common.h. The bpf_arena_common.h definition is
> guarded with an ifndef to allow for inclusion after bpf_atomic.h,
> but the opposite does not hold. Add an extra guard to avoid requiring
> a specific order for the headers.
>
> Signed-off-by: Emil Tsalapatis (Meta) <emil@etsalapatis.com>
> ---
> tools/testing/selftests/bpf/bpf_atomic.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/bpf_atomic.h b/tools/testing/selftests/bpf/bpf_atomic.h
> index c550e5711967..d89a22d63c1c 100644
> --- a/tools/testing/selftests/bpf/bpf_atomic.h
> +++ b/tools/testing/selftests/bpf/bpf_atomic.h
> @@ -42,7 +42,9 @@ extern bool CONFIG_X86_64 __kconfig __weak;
>
> #define READ_ONCE(x) (*(volatile typeof(x) *)&(x))
>
> +#ifndef WRITE_ONCE
> #define WRITE_ONCE(x, val) ((*(volatile typeof(x) *)&(x)) = (val))
> +#endif
I wonder if we can avoid duplicating this macros, for example by
including bpf_atomic.h in the bpf_arena_common.h.
>
> #define cmpxchg(p, old, new) __sync_val_compare_and_swap((p), old, new)
>
next prev parent reply other threads:[~2026-01-27 19:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 18:15 [PATCH v2 00/13] bpf: Add arena ASAN runtime and BPF library Emil Tsalapatis
2026-01-27 18:15 ` [PATCH v2 01/13] bpf: Add bpf_stream_print_stack stack dumping kfunc Emil Tsalapatis
2026-01-27 19:17 ` Mykyta Yatsenko
2026-01-27 23:23 ` Emil Tsalapatis
2026-01-27 23:53 ` Kumar Kartikeya Dwivedi
2026-01-27 18:15 ` [PATCH v2 02/13] bpf: Allow BPF stream kfuncs while holding a lock Emil Tsalapatis
2026-01-28 0:01 ` Kumar Kartikeya Dwivedi
2026-01-27 18:15 ` [PATCH v2 03/13] selftests: bpf: Move bpf_arena_spin_lock.h to the top level Emil Tsalapatis
2026-01-28 0:13 ` Kumar Kartikeya Dwivedi
2026-01-27 18:16 ` [PATCH v2 04/13] selftests: bpf: Make WRITE_ONCE macro in bpf_atomic.h conditional Emil Tsalapatis
2026-01-27 19:26 ` Mykyta Yatsenko [this message]
2026-01-27 23:41 ` Emil Tsalapatis
2026-01-27 23:56 ` Kumar Kartikeya Dwivedi
2026-01-27 18:16 ` [PATCH v2 05/13] selftests: bpf: Add basic libarena scaffolding Emil Tsalapatis
2026-01-28 0:32 ` Alexei Starovoitov
2026-01-28 0:42 ` Kumar Kartikeya Dwivedi
2026-01-27 18:16 ` [PATCH v2 06/13] selftests: bpf: Add arena ASAN runtime to libarena Emil Tsalapatis
2026-01-28 2:27 ` Alexei Starovoitov
2026-01-27 18:16 ` [PATCH v2 07/13] selftests: bpf: Add ASAN support for libarena selftests Emil Tsalapatis
2026-01-27 18:38 ` bot+bpf-ci
2026-01-27 18:45 ` Emil Tsalapatis
2026-01-27 18:16 ` [PATCH v2 08/13] selftest: bpf: Add bump allocator for libarena Emil Tsalapatis
2026-01-28 2:36 ` Alexei Starovoitov
2026-01-27 18:16 ` [PATCH v2 09/13] selftests: bpf: Add libarena selftests for the bump allocator Emil Tsalapatis
2026-01-27 18:16 ` [PATCH v2 10/13] selftest: bpf: Add libarena stack allocator Emil Tsalapatis
2026-01-27 18:49 ` bot+bpf-ci
2026-01-27 18:16 ` [PATCH v2 11/13] selftests: bpf: Add selftests for the " Emil Tsalapatis
2026-01-28 2:35 ` Alexei Starovoitov
2026-01-27 18:16 ` [PATCH v2 12/13] selftests: bpf: Add buddy allocator for libarena Emil Tsalapatis
2026-01-27 18:49 ` bot+bpf-ci
2026-01-27 18:16 ` [PATCH v2 13/13] selftests: bpf: Add selftests for the libarena buddy allocator Emil Tsalapatis
2026-01-27 18:38 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92fcc97e-1313-424e-b67d-d86effda3481@gmail.com \
--to=mykyta.yatsenko5@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=etsal@meta.com \
--cc=ihor.solodrai@linux.dev \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=puranjay@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox