From: Philo Lu <lulie@linux.alibaba.com>
To: Viktor Malik <vmalik@redhat.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: skip the timer_lockup test for single-CPU nodes
Date: Fri, 8 Nov 2024 12:41:05 +0800 [thread overview]
Message-ID: <940bc790-62ea-44c6-bd7c-e8bb1f747678@linux.alibaba.com> (raw)
In-Reply-To: <20241107115231.75200-1-vmalik@redhat.com>
On 2024/11/7 19:52, Viktor Malik wrote:
> The timer_lockup test needs 2 CPUs to work, on single-CPU nodes it fails
> to set thread affinity to CPU 1 since it doesn't exist:
>
> # ./test_progs -t test_lockup
nit: s/test_lockup/timer_lockup
> test_timer_lockup:PASS:timer_lockup__open_and_load 0 nsec
> test_timer_lockup:PASS:pthread_create thread1 0 nsec
> test_timer_lockup:PASS:pthread_create thread2 0 nsec
> timer_lockup_thread:PASS:cpu affinity 0 nsec
> timer_lockup_thread:FAIL:cpu affinity unexpected error: 22 (errno 0)
> test_timer_lockup:PASS: 0 nsec
> #406 timer_lockup:FAIL
>
> Skip the test if only 1 CPU is available.
>
> Signed-off-by: Viktor Malik <vmalik@redhat.com>
> Fixes: 50bd5a0c658d1 ("selftests/bpf: Add timer lockup selftest")
> ---
Can reproduce this issue and this patch solves it.
Tested-by: Philo Lu <lulie@linux.alibaba.com>
Cheers.
--
Philo
next prev parent reply other threads:[~2024-11-08 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:52 [PATCH bpf-next] selftests/bpf: skip the timer_lockup test for single-CPU nodes Viktor Malik
2024-11-08 4:41 ` Philo Lu [this message]
2024-11-09 20:06 ` Kumar Kartikeya Dwivedi
2024-11-09 20:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=940bc790-62ea-44c6-bd7c-e8bb1f747678@linux.alibaba.com \
--to=lulie@linux.alibaba.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=vmalik@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox