BPF List
 help / color / mirror / Atom feed
From: Cupertino Miranda <cupertino.miranda@oracle.com>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
	Ihor Solodrai <ihor.solodrai@pm.me>
Cc: Andrew Pinski via Gcc <gcc@gcc.gnu.org>,
	bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Manu Bretelle <chantra@meta.com>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Mykola Lysenko <mykolal@fb.com>,
	Yonghong Song <yonghong.song@linux.dev>,
	David Faust <david.faust@oracle.com>,
	Andrew Pinski <pinskia@gmail.com>
Subject: Re: Announcement: GCC BPF is now being tested on BPF CI
Date: Fri, 17 Jan 2025 08:33:37 +0000	[thread overview]
Message-ID: <9492b728-ce7c-41bd-b954-6981bf639438@oracle.com> (raw)
In-Reply-To: <877c6uqpir.fsf@oracle.com>

I remind that just as bad as the decl_tags it also misses a solution to 
the attribute ((preserve_access_index)).
Something like #pragma clang push/pop is not viable in GCC.

Jose proposed the patch in:
  
https://lore.kernel.org/bpf/20240503111836.25275-1-jose.marchesi@oracle.com/

Maybe you could accept his patch in the meanwhile, and work on the 
intended improvements later. It would be passing more tests then roughly 
half.

Thanks

> 
> Thank you for getting this up and running!
> 
>> Hi everyone.
>>
>> GCC BPF support in BPF CI has been landed.
>>
>> The BPF CI dashboard is here:
>> https://github.com/kernel-patches/bpf/actions/workflows/test.yml
>>
>> A summary of what happens on CI (relevant to GCC BPF):
>>    * Linux Kernel is built on a target source revision
>>    * Latest snapshots of GCC 15 and binutils are downloaded
>>      * GCC BPF compiler is built and cached
>>    * selftests/bpf test runners are built with BPF_GCC variable set
>>      * BPF_GCC triggers a build of test_progs-bpf_gcc runner
>>      * The runner contains BPF binaries produced by GCC BPF
>>    * In a separate job, test_progs-bpf_gcc is executed within qemu
>>      against the target kernel
>>
>> GCC BPF is only tested on x86_64.
>>
>> On x86_64 we test the following toolchains for building the kernel and
>> test runners: gcc-13 (ubuntu 24 default), clang-17, clang-18.
>>
>> An example of successful test run (you have to login to github to see
>> the logs):
>> https://github.com/kernel-patches/bpf/actions/runs/12816136141/job/35736973856
>>
>> Currently 2513 of 4340 tests pass for GCC BPF, so a bit more than a half.
>>
>> Effective BPF selftests denylist for GCC BPF is located here:
>> https://github.com/kernel-patches/vmtest/blob/master/ci/vmtest/configs/DENYLIST.test_progs-bpf_gcc
>>
>> When a patch is submitted to BPF, normally a corresponding PR for
>> kernel-patches/bpf github repo is automatically created to trigger a
>> BPF CI run for this change. PRs opened manually will do that too, and
>> this can be used to test patches before submission.
>>
>> Since the CI automatically pulls latest GCC snapshot, a change in GCC
>> can potentially cause CI failures unrelated to Linux changes being
>> tested. This is not the only dependency like that, of course.
>>
>> In such situations, a change is usually made in CI code to mitigate
>> the failure in order to unblock the pipeline for patches. If that
>> happens with GCC, someone (most likely me) will have to reach out to
>> GCC team. I guess gcc@gcc.gnu.org would be the default point of
>> contact, but if there are specific people who should be notified
>> please let me know.


  reply	other threads:[~2025-01-17  8:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 20:44 Announcement: GCC BPF is now being tested on BPF CI Ihor Solodrai
2025-01-16 22:05 ` Ihor Solodrai
2025-01-16 23:58   ` Jose E. Marchesi
2025-01-17  3:32     ` Ihor Solodrai
2025-01-17 10:44       ` Jose E. Marchesi
2025-01-17 17:55         ` Ihor Solodrai
2025-01-17 18:00           ` Sam James
2025-01-17  0:01   ` Jose E. Marchesi
2025-01-16 23:59 ` Jose E. Marchesi
2025-01-17  8:33   ` Cupertino Miranda [this message]
2025-01-17 17:56     ` Andrii Nakryiko
2025-01-17 13:44 ` Mark Wielaard
2025-01-17 18:09   ` Ihor Solodrai
  -- strict thread matches above, loose matches on Subject: below --
2025-01-16 21:49 Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9492b728-ce7c-41bd-b954-6981bf639438@oracle.com \
    --to=cupertino.miranda@oracle.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=chantra@meta.com \
    --cc=david.faust@oracle.com \
    --cc=eddyz87@gmail.com \
    --cc=gcc@gcc.gnu.org \
    --cc=ihor.solodrai@pm.me \
    --cc=jose.marchesi@oracle.com \
    --cc=mykolal@fb.com \
    --cc=pinskia@gmail.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox