From: Eduard Zingerman <eddyz87@gmail.com>
To: Yonghong Song <yonghong.song@linux.dev>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH bpf-next v2 2/2] selftests/bpf: Add tests for ldsx of pkt data/data_end/data_meta accesses
Date: Thu, 18 Jul 2024 13:58:49 -0700 [thread overview]
Message-ID: <96b552a47c11488438c7ac189777838826f4415f.camel@gmail.com> (raw)
In-Reply-To: <20240718050228.3543663-1-yonghong.song@linux.dev>
On Wed, 2024-07-17 at 22:02 -0700, Yonghong Song wrote:
> The following tests are added to verifier_ldsx.c:
> - sign extension of data/data_end/data_meta for tcx programs.
> The actual checking is in bpf_skb_is_valid_access() which
> is called by sk_filter, cg_skb, lwt, tc(tcx) and sk_skb.
> - sign extension of data/data_end/data_meta for xdp programs.
> - sign extension of data/data_end for flow_dissector programs.
>
> All newly-added tests have verification failure with message
> "invalid bpf_context access". Without previous patch, all these
> tests succeeded verification.
>
> Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...]
next prev parent reply other threads:[~2024-07-18 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 5:02 [PATCH bpf-next v2 1/2] bpf: Fail verification for sign-extension of packet data/data_end/data_meta Yonghong Song
2024-07-18 5:02 ` [PATCH bpf-next v2 2/2] selftests/bpf: Add tests for ldsx of pkt data/data_end/data_meta accesses Yonghong Song
2024-07-18 20:58 ` Eduard Zingerman [this message]
2024-07-19 18:49 ` bot+bpf-ci
2024-07-19 23:51 ` bot+bpf-ci
2024-07-23 0:49 ` bot+bpf-ci
2024-07-23 2:03 ` bot+bpf-ci
2024-07-23 1:58 ` [PATCH bpf-next v2 1/2] bpf: Fail verification for sign-extension of packet data/data_end/data_meta Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96b552a47c11488438c7ac189777838826f4415f.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox