Re: [PATCH bpf v1 1/2] bpf: Fix tracing of kfuncs with implicit args

[Ihor Solodrai <ihor.solodrai@linux.dev>]

On 7/10/26 10:40 AM, Kumar Kartikeya Dwivedi wrote:
> On Fri Jul 10, 2026 at 7:34 PM CEST, Ihor Solodrai wrote:
>> On 7/10/26 10:23 AM, Kumar Kartikeya Dwivedi wrote:
>>> [...]
>>>
>>> Also, why not do it for BPF_TRACE_ITER case as well? I just feel keeping it
>>> consistent may outweigh figuring out whether it's necessary in that case or not,
>>> etc.
>>
>>
>> I mentioned this in the patch description:
>>
>>   The BPF_TRACE_ITER case distills a registered iterator's
>>   prototype, and bpf_struct_ops_desc_init() distills the
>>   function-pointer members of a struct_ops type. Neither is
>>   a kfunc, and so can't have implicit arguments.
>>
> 
> Yeah, I saw that, but abstracting that inside the function and not having to
> think from the caller about those details would be better. That said, I don't
> have any strong preference, it is obviously correct as it is.

Let's keep the fix patch minimal. I think we can do a more thoughtful
refactoring as a follow up for bpf-next. Hopefully I'll find time for
this in not so distant future.

Just sent a v2 with a module ref fix and a brief cover.

> 
>>
>>>
>>> Please supply a cover letter in the next version too since you're sending
>>> multiple patches.
>>
>> I used the first patch's message as a cover letter, since it's
>> just a fix + selftest pair.
>>
>> The series could be split further into refactoring changes, but I thought
>> it'll be easier to backport if the fix is in a single self-contained patch.
>>
>> I think we want the fix to get into 7.2, and backport it to 7.1.
>>
>> If it's ok to carry separate refactoring patches there, then I'll split.
>> Kartikeya, wdyt?
>>
> 
> You can still keep the patches as is, but just add a cover letter, it will not
> affect backporting. The cover letter is just to summarize the series and the fix
> in the merge commit. Also, my understanding is that with the Fixes: tag, it
> should automatically be picked up for stable kernels.