From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610651FA1 for ; Thu, 4 Jan 2024 02:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N6UhPIK+" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a277339dcf4so3041866b.2 for ; Wed, 03 Jan 2024 18:25:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704335151; x=1704939951; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=bUeQfxnT2BRybuemrqmzMN4OX1PKAtYT+FCUNlHRr00=; b=N6UhPIK+LGo/HOTnEpTQRGSej9oXhZTm87pJ3uEeZFeaJ01oudxLnr+LWKRJhQ26Hm A/MGqZZJlurxbXxgKg4p3mGsaqh3cKvr76UZFeSNPg6miwgOdqab+ndUouaSVOBW9mI+ VHn/d59K7Zk93GmuhFMgHlOWHek5o78UxqnLGMbyEIBNa9qIXxo/Zz0Ym8p8p57c5dOC XznPkTuM8Tk5cDPmwBCv+bY3DMPRR2GGCEYp4kK+GN6tmDdF4S1zFlMjmRUIMlIsPjBj oXZoQ9YhXDeYrsCyn3U2CsPGNROj9MAtvwrg7mRXUMKtvSYg6xAn3dftrR1phx2+GvE3 ucvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704335151; x=1704939951; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bUeQfxnT2BRybuemrqmzMN4OX1PKAtYT+FCUNlHRr00=; b=LsBmelxubc+ShVqIz8hLeQiIEsdSc4GrF4dEtFetRTJPnBRah5E9KS2ZEVT4Gkifyn rWDKUlPjLGl/5cZodJXtYr+G1Qg5sCJM7EqeKAQYek4qWaK+OzzgNr5ebH2BBnmMX4fJ j5eStFjKy2ErgRukG95ov/C3wjJ5A4ldoX0a8SKejcWSi2/Y7j1UBWguGN3M+/Ku0BLI ZVuXShvPLoXREOquKo8GNjbjXamUHc7AgPcH3+7RqVx1HOvUZSBOp+8ZBQvXMDVuaxmh Yjxkv/LfixaIJVlXK6o/l0irhX5MxpB0OsjxEF0ukjF0lrKezSaqoqjpsRJiYTDVW3to OdvA== X-Gm-Message-State: AOJu0YyMwcbK32kIhNLeLzhj3OvPeV9jWiaYcF/o4Du0vjdIXcn9xQOV CBmo1L8yRw2iKXWJTi5SVO4= X-Google-Smtp-Source: AGHT+IFdxV2nQXA7b78YQ3LWDpUNcAcKUm1O92PEqfGOpjTrgmfjs3VDLEXUjHc4SrQqIuuOv0z7Cw== X-Received: by 2002:a17:906:3987:b0:a28:2374:f39d with SMTP id h7-20020a170906398700b00a282374f39dmr2024108eje.50.1704335151547; Wed, 03 Jan 2024 18:25:51 -0800 (PST) Received: from [192.168.1.95] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id zx13-20020a170907348d00b00a2871b38ca0sm1636312ejb.110.2024.01.03.18.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 18:25:51 -0800 (PST) Message-ID: <975c160668650d24f479bc87916cf15c6e2705a7.camel@gmail.com> Subject: Re: [PATCH bpf-next 04/15] bpf: Make bpf_for_each_spilled_reg consider narrow spills From: Eduard Zingerman To: Maxim Mikityanskiy Cc: bpf@vger.kernel.org Date: Thu, 04 Jan 2024 04:25:50 +0200 In-Reply-To: <20231220214013.3327288-5-maxtram95@gmail.com> References: <20231220214013.3327288-1-maxtram95@gmail.com> <20231220214013.3327288-5-maxtram95@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWWA+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2023-12-20 at 23:40 +0200, Maxim Mikityanskiy wrote: > > From: Maxim Mikityanskiy > >=20 > > Adjust the check in bpf_get_spilled_reg to take into account spilled > > registers narrower than 64 bits. That allows find_equal_scalars to > > properly adjust the range of all spilled registers that have the same > > ID. Before this change, it was possible for a register and a spilled > > register to have the same IDs but different ranges if the spill was > > narrower than 64 bits and a range check was performed on the register. > >=20 > > Signed-off-by: Maxim Mikityanskiy > > --- Acked-by: Eduard Zingerman I double checked, all uses of bpf_for_each_reg_in_vstate() except in find_equal_scalars() operate on 64-bit values (pointers), so this change is ok.