From: Daniel Borkmann <daniel@iogearbox.net>
To: Yonghong Song <yonghong.song@linux.dev>,
Jerome Marchand <jmarchan@redhat.com>,
bpf@vger.kernel.org, Andrii Nakryiko <andrii@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/bpf: Fix compilation error in get_uprobe_offset()
Date: Thu, 19 Dec 2024 13:27:59 +0100 [thread overview]
Message-ID: <975c7d53-bbca-4ed7-9635-53f5741ee2ff@iogearbox.net> (raw)
In-Reply-To: <2397f348-9d7f-4ea4-bf95-ed1452fa2156@linux.dev>
On 12/19/24 2:28 AM, Yonghong Song wrote:
> On 12/18/24 9:57 AM, Jerome Marchand wrote:
>> In get_uprobe_offset(), the call to procmap_query() use the constant
>> PROCMAP_QUERY_VMA_EXECUTABLE, even if PROCMAP_QUERY is not defined.
>>
>> Define PROCMAP_QUERY_VMA_EXECUTABLE when PROCMAP_QUERY isn't.
>>
>> Fixes: 4e9e07603ecd ("selftests/bpf: make use of PROCMAP_QUERY ioctl if available")
>> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
>
> Acked-by: Yonghong Song <yonghong.song@linux.dev>
lgtm, I've wrapped this in an ifndef while applying.
next prev parent reply other threads:[~2024-12-19 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 17:57 [PATCH] selftests/bpf: Fix compilation error in get_uprobe_offset() Jerome Marchand
2024-12-19 1:28 ` Yonghong Song
2024-12-19 12:27 ` Daniel Borkmann [this message]
2024-12-19 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=975c7d53-bbca-4ed7-9635-53f5741ee2ff@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox