BPF List
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Alan Maguire <alan.maguire@oracle.com>, Jiri Olsa <olsajiri@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>, <bpf@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, <dwarves@vger.kernel.org>
Subject: Re: [PATCH] fix linux kernel BTF builds: increase max percpu variables by 10x
Date: Wed, 28 Feb 2024 15:21:16 -0800	[thread overview]
Message-ID: <983b98db-79c0-4178-b88f-61f39d147cf7@nvidia.com> (raw)
In-Reply-To: <856564cf-fba4-4473-bfa9-e9b03115abd1@oracle.com>

On 2/28/24 04:04, Alan Maguire wrote:
> On 28/02/2024 09:20, Jiri Olsa wrote:
>> On Tue, Feb 27, 2024 at 07:21:42PM -0800, John Hubbard wrote:
...
>> do you have an actual count of percpu variables for your config?

That's a very reasonable question...

>> 10x seems a lot to me

Me too. This was a "make the problem go away now please" type of "fix". :)

>>
>> this might be a workaround, but we should make encoder->percpu.vars
>> dynamically allocated like we do for functions

Yes, that's a much better design imho.

>>
>> jirka
>>
> 
> Good idea Jiri; John would you mind trying the attached patch? Thanks!

It works perfectly for me. For that patch, please feel free to add:

Tested-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA


  reply	other threads:[~2024-02-28 23:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  3:21 [PATCH] fix linux kernel BTF builds: increase max percpu variables by 10x John Hubbard
2024-02-28  9:20 ` Jiri Olsa
2024-02-28 12:04   ` Alan Maguire
2024-02-28 23:21     ` John Hubbard [this message]
2024-02-29  9:17       ` Alan Maguire
2024-02-29 18:15         ` John Hubbard
2024-03-01 14:14           ` Jiri Olsa
2024-03-01 18:32             ` John Hubbard
2024-03-01 19:15               ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=983b98db-79c0-4178-b88f-61f39d147cf7@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=acme@redhat.com \
    --cc=alan.maguire@oracle.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=dwarves@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olsajiri@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox