From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin Lau <kafai@meta.com>, Kernel Team <kernel-team@meta.com>,
Eduard <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Mykyta Yatsenko <yatsenko@meta.com>
Subject: Re: [PATCH bpf-next v8 8/9] selftests/bpf: BPF task work scheduling tests
Date: Tue, 23 Sep 2025 08:50:11 -0700 [thread overview]
Message-ID: <99b04dfb-4d0e-4446-9957-72af96afd94b@linux.dev> (raw)
In-Reply-To: <CAADnVQKS0bWcSJns4zF_mmKnh4+is3faM5wPt1O-Y0FdiP7UeQ@mail.gmail.com>
On 9/23/25 7:59 AM, Alexei Starovoitov wrote:
> On Tue, Sep 23, 2025 at 4:24 AM Mykyta Yatsenko
> <mykyta.yatsenko5@gmail.com> wrote:
>> +static void task_work_run(const char *prog_name, const char *map_name)
>> [...]
>
> Applied, but this one is buggy.
> It seems to be missing perf_event cleanup.
> Pls send a fix asap.
>
> ./test_progs -t bpf_cookie
> ...
> #18 bpf_cookie:OK
> Summary: 1/11 PASSED, 0 SKIPPED, 0 FAILED
>
> ./test_progs -t task_work
> ...
> #434 task_work:OK
> #435/1 task_work_stress/no_delete:OK
> #435/2 task_work_stress/with_delete:OK
> #435 task_work_stress:OK
> Summary: 2/9 PASSED, 0 SKIPPED, 0 FAILED
>
> ./test_progs -t bpf_cookie
> test_bpf_cookie:PASS:skel_open 0 nsec
> #18/1 bpf_cookie/kprobe:OK
> #18/2 bpf_cookie/multi_kprobe_link_api:OK
> #18/3 bpf_cookie/multi_kprobe_attach_api:OK
> #18/4 bpf_cookie/uprobe:OK
> #18/5 bpf_cookie/multi_uprobe_attach_api:OK
> #18/6 bpf_cookie/tracepoint:OK
> pe_subtest:FAIL:perf_fd unexpected perf_fd: actual -1 < expected 0
> #18/7 bpf_cookie/perf_event:FAIL
> #18/8 bpf_cookie/trampoline:OK
> #18/9 bpf_cookie/lsm:OK
> #18/10 bpf_cookie/tp_btf:OK
> #18/11 bpf_cookie/raw_tp:OK
> #18 bpf_cookie:FAIL
>
>
> Ihor,
>
> we probably should extend CI to run test_progs twice in the same VM
> to catch such cleanup issues.
Acked. Will come up with something.
next prev parent reply other threads:[~2025-09-23 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 11:23 [PATCH bpf-next v8 0/9] bpf: Introduce deferred task context execution Mykyta Yatsenko
2025-09-23 11:23 ` [PATCH bpf-next v8 1/9] bpf: refactor special field-type detection Mykyta Yatsenko
2025-09-23 11:23 ` [PATCH bpf-next v8 2/9] bpf: extract generic helper from process_timer_func() Mykyta Yatsenko
2025-09-23 11:23 ` [PATCH bpf-next v8 3/9] bpf: htab: extract helper for freeing special structs Mykyta Yatsenko
2025-09-23 11:23 ` [PATCH bpf-next v8 4/9] bpf: verifier: permit non-zero returns from async callbacks Mykyta Yatsenko
2025-09-23 11:24 ` [PATCH bpf-next v8 5/9] bpf: bpf task work plumbing Mykyta Yatsenko
2025-09-23 11:24 ` [PATCH bpf-next v8 6/9] bpf: extract map key pointer calculation Mykyta Yatsenko
2025-09-23 11:24 ` [PATCH bpf-next v8 7/9] bpf: task work scheduling kfuncs Mykyta Yatsenko
2026-07-24 11:22 ` Heiko Carstens
2026-07-24 13:06 ` Mykyta Yatsenko
2026-07-24 15:29 ` Heiko Carstens
2025-09-23 11:24 ` [PATCH bpf-next v8 8/9] selftests/bpf: BPF task work scheduling tests Mykyta Yatsenko
2025-09-23 14:59 ` Alexei Starovoitov
2025-09-23 15:50 ` Ihor Solodrai [this message]
2025-09-23 11:24 ` [PATCH bpf-next v8 9/9] selftests/bpf: add bpf task work stress tests Mykyta Yatsenko
2025-09-23 15:20 ` [PATCH bpf-next v8 0/9] bpf: Introduce deferred task context execution patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99b04dfb-4d0e-4446-9957-72af96afd94b@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kafai@meta.com \
--cc=kernel-team@meta.com \
--cc=memxor@gmail.com \
--cc=mykyta.yatsenko5@gmail.com \
--cc=yatsenko@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox