From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C0CC4332F for ; Fri, 25 Feb 2022 21:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238100AbiBYVNq (ORCPT ); Fri, 25 Feb 2022 16:13:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238077AbiBYVNp (ORCPT ); Fri, 25 Feb 2022 16:13:45 -0500 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85419182DAF for ; Fri, 25 Feb 2022 13:13:12 -0800 (PST) Received: by mail-il1-x131.google.com with SMTP id w4so5303975ilj.5 for ; Fri, 25 Feb 2022 13:13:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WYW51JD9bbPEQ4lnb5EQmERyn2Zcwqc61RWoRLurrq8=; b=HHnODJ3qiuqSo7UIQya4dlBAsYrgNK8HXIoHRrZn/6MA+vMXF7v16ZhVdvOu8UL+fI Vj0FULIVOAOdxgfBoyo+HhQhl95M5EMHhHHLsiLX3wyA3Rgy0wmHNKcaEGK0Rvt/bFjM HEifVucNoVhCZnNspWvAH5gZOr/wO+DNVXU9g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WYW51JD9bbPEQ4lnb5EQmERyn2Zcwqc61RWoRLurrq8=; b=IWMU0xLQGQIInehBGtzl2EciGK+H/Qj2ZL9LKZywJzPt6r2UoT6yj3xQzK6ki+E6xj quTFF3/cId3uZ6N215wPBzk+Zo5ezGvR/rUQZJ4qYc7irT7cv4x2AfcjQFy7RSjCLwuJ oJ6y0gsRQ2bmzXzmfWF7QV86xjr/sWbRPPIX+6rvA+pveo/y/nG3IjXx8plt0Tx+C3wb qCB9fgkcIWKhvEihIaNJSnigszh5UyaliZ+gFKE3HvDZsJPGcq4dEHhsWtngkOwQtow6 huV+5HuyMy+LNDtkXecZ2CbEKjNTFRuE547ZLTC897lDqcK7Ka/bRyByW2L5rRM/pJOy ybxA== X-Gm-Message-State: AOAM53111gqBJPr8n9cLOKI1K4jK5YEiNfpGHdCnE345hwK2lg7QowzF ucCvyFhLU1lUCGPQkfVr0+ntFWeD7XyWrg== X-Google-Smtp-Source: ABdhPJwkwthxHErq15favBEsQG6uVFyjOR90Yv8knXt32vNlTmla+qY7A+YblVRqe/QVDDRbOsnmGg== X-Received: by 2002:a92:8e4a:0:b0:2bc:1a0d:ed41 with SMTP id k10-20020a928e4a000000b002bc1a0ded41mr8097251ilh.96.1645823591441; Fri, 25 Feb 2022 13:13:11 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id c9-20020a92b749000000b002c22c39554fsm1930048ilm.31.2022.02.25.13.13.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Feb 2022 13:13:11 -0800 (PST) Subject: Re: [PATCH V2] selftests: Fix build when $(O) points to a relative path To: Muhammad Usama Anjum , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Shuah Khan Cc: kernel@collabora.com, kernelci@groups.io, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org References: <20220216223817.1386745-1-usama.anjum@collabora.com> <46489cd9-fb7a-5a4b-7f36-1c9f6566bd93@collabora.com> <63870982-62ba-97f2-5ee2-d4457a7a5cdb@linuxfoundation.org> From: Shuah Khan Message-ID: <9a643612-ea85-7b28-a792-770927836d43@linuxfoundation.org> Date: Fri, 25 Feb 2022 14:13:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <63870982-62ba-97f2-5ee2-d4457a7a5cdb@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 2/25/22 11:01 AM, Shuah Khan wrote: > On 2/25/22 10:22 AM, Muhammad Usama Anjum wrote: >> Any thoughts about it? >> > > No to post please. > >> On 2/17/22 3:38 AM, Muhammad Usama Anjum wrote: >>> Build of bpf and tc-testing selftests fails when the relative path of >>> the build directory is specified. >>> >>> make -C tools/testing/selftests O=build0 >>> make[1]: Entering directory '/linux_mainline/tools/testing/selftests/bpf' >>> ../../../scripts/Makefile.include:4: *** O=build0 does not exist.  Stop. >>> make[1]: Entering directory '/linux_mainline/tools/testing/selftests/tc-testing' >>> ../../../scripts/Makefile.include:4: *** O=build0 does not exist.  Stop. >>> >>> Makefiles of bpf and tc-testing include scripts/Makefile.include file. >>> This file has sanity checking inside it which checks the output path. >>> The output path is not relative to the bpf or tc-testing. The sanity >>> check fails. Expand the output path to get rid of this error. The fix is >>> the same as mentioned in commit 150a27328b68 ("bpf, preload: Fix build >>> when $(O) points to a relative path"). >>> >>> Signed-off-by: Muhammad Usama Anjum >>> --- >>> Changes in V2: >>> Add more explaination to the commit message. >>> Support make install as well. > Does the same happen when you use make kselftest-all? I am unable to reproduce what you are seeing? thanks, -- Shuah