From: Yonghong Song <yonghong.song@linux.dev>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>, bpf@vger.kernel.org
Subject: Re: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
Date: Wed, 26 Jul 2023 21:44:32 -0700 [thread overview]
Message-ID: <9ac948b7-d32c-a567-c9ce-b7f67d65d8de@linux.dev> (raw)
In-Reply-To: <20230726092543.6362-1-jose.marchesi@oracle.com>
On 7/26/23 2:25 AM, Jose E. Marchesi wrote:
> This patch fixes the documentation of the BPF_NEG instruction to
> denote that it does not use the source register operand.
>
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
> ---
> Documentation/bpf/standardization/instruction-set.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
> index 751e657973f0..6ef5534b410a 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -165,7 +165,7 @@ BPF_OR 0x40 dst \|= src
> BPF_AND 0x50 dst &= src
> BPF_LSH 0x60 dst <<= (src & mask)
> BPF_RSH 0x70 dst >>= (src & mask)
> -BPF_NEG 0x80 dst = -src
> +BPF_NEG 0x80 dst = -dst
> BPF_MOD 0x90 dst = (src != 0) ? (dst % src) : dst
> BPF_XOR 0xa0 dst ^= src
> BPF_MOV 0xb0 dst = src
next prev parent reply other threads:[~2023-07-27 4:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 9:25 [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst Jose E. Marchesi
2023-07-26 13:28 ` Dave Thaler
2023-07-26 13:28 ` [Bpf] " Dave Thaler
2023-07-26 13:30 ` Jose E. Marchesi
2023-07-26 13:30 ` Jose E. Marchesi
2023-07-27 4:44 ` Yonghong Song [this message]
2023-07-28 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ac948b7-d32c-a567-c9ce-b7f67d65d8de@linux.dev \
--to=yonghong.song@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox