[PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst

[PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst

[Jose E. Marchesi]

This patch fixes the documentation of the BPF_NEG instruction to
denote that it does not use the source register operand.

Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
---
 Documentation/bpf/standardization/instruction-set.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
index 751e657973f0..6ef5534b410a 100644
--- a/Documentation/bpf/standardization/instruction-set.rst
+++ b/Documentation/bpf/standardization/instruction-set.rst
@@ -165,7 +165,7 @@ BPF_OR    0x40   dst \|= src
 BPF_AND   0x50   dst &= src
 BPF_LSH   0x60   dst <<= (src & mask)
 BPF_RSH   0x70   dst >>= (src & mask)
-BPF_NEG   0x80   dst = -src
+BPF_NEG   0x80   dst = -dst
 BPF_MOD   0x90   dst = (src != 0) ? (dst % src) : dst
 BPF_XOR   0xa0   dst ^= src
 BPF_MOV   0xb0   dst = src
-- 
2.30.2

RE: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst

[Dave Thaler]

> -----Original Message-----
> From: Jose E. Marchesi <jose.marchesi@oracle.com>
> Sent: Wednesday, July 26, 2023 2:26 AM
> To: bpf@vger.kernel.org
> Subject: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
> 
> This patch fixes the documentation of the BPF_NEG instruction to denote
> that it does not use the source register operand.
> 
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
> ---
>  Documentation/bpf/standardization/instruction-set.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index 751e657973f0..6ef5534b410a 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -165,7 +165,7 @@ BPF_OR    0x40   dst \|= src
>  BPF_AND   0x50   dst &= src
>  BPF_LSH   0x60   dst <<= (src & mask)
>  BPF_RSH   0x70   dst >>= (src & mask)
> -BPF_NEG   0x80   dst = -src
> +BPF_NEG   0x80   dst = -dst
>  BPF_MOD   0x90   dst = (src != 0) ? (dst % src) : dst
>  BPF_XOR   0xa0   dst ^= src
>  BPF_MOV   0xb0   dst = src
> --
> 2.30.2

Acked-by: Dave Thaler <dthaler@microsoft.com>

Also, all changes to files in the standardization directory should also be cc'ed
to bpf@ietf.org, which I am doing on this email.

Dave

Re: [Bpf] [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst

[Dave Thaler]

> -----Original Message-----
> From: Jose E. Marchesi <jose.marchesi@oracle.com>
> Sent: Wednesday, July 26, 2023 2:26 AM
> To: bpf@vger.kernel.org
> Subject: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
> 
> This patch fixes the documentation of the BPF_NEG instruction to denote
> that it does not use the source register operand.
> 
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
> ---
>  Documentation/bpf/standardization/instruction-set.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index 751e657973f0..6ef5534b410a 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -165,7 +165,7 @@ BPF_OR    0x40   dst \|= src
>  BPF_AND   0x50   dst &= src
>  BPF_LSH   0x60   dst <<= (src & mask)
>  BPF_RSH   0x70   dst >>= (src & mask)
> -BPF_NEG   0x80   dst = -src
> +BPF_NEG   0x80   dst = -dst
>  BPF_MOD   0x90   dst = (src != 0) ? (dst % src) : dst
>  BPF_XOR   0xa0   dst ^= src
>  BPF_MOV   0xb0   dst = src
> --
> 2.30.2

Acked-by: Dave Thaler <dthaler@microsoft.com>

Also, all changes to files in the standardization directory should also be cc'ed
to bpf@ietf.org, which I am doing on this email.

Dave

-- 
Bpf mailing list
Bpf@ietf.org
https://www.ietf.org/mailman/listinfo/bpf

Re: [Bpf] [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst

[Jose E. Marchesi]

>> -----Original Message-----
>> From: Jose E. Marchesi <jose.marchesi@oracle.com>
>> Sent: Wednesday, July 26, 2023 2:26 AM
>> To: bpf@vger.kernel.org
>> Subject: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
>> 
>> This patch fixes the documentation of the BPF_NEG instruction to denote
>> that it does not use the source register operand.
>> 
>> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
>> ---
>>  Documentation/bpf/standardization/instruction-set.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/bpf/standardization/instruction-set.rst
>> b/Documentation/bpf/standardization/instruction-set.rst
>> index 751e657973f0..6ef5534b410a 100644
>> --- a/Documentation/bpf/standardization/instruction-set.rst
>> +++ b/Documentation/bpf/standardization/instruction-set.rst
>> @@ -165,7 +165,7 @@ BPF_OR    0x40   dst \|= src
>>  BPF_AND   0x50   dst &= src
>>  BPF_LSH   0x60   dst <<= (src & mask)
>>  BPF_RSH   0x70   dst >>= (src & mask)
>> -BPF_NEG   0x80   dst = -src
>> +BPF_NEG   0x80   dst = -dst
>>  BPF_MOD   0x90   dst = (src != 0) ? (dst % src) : dst
>>  BPF_XOR   0xa0   dst ^= src
>>  BPF_MOV   0xb0   dst = src
>> --
>> 2.30.2
>
> Acked-by: Dave Thaler <dthaler@microsoft.com>
>
> Also, all changes to files in the standardization directory should also be cc'ed
> to bpf@ietf.org, which I am doing on this email.

Will do in future posts.  Thanks for CCing.

> Dave

Re: [Bpf] [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst

[Jose E. Marchesi]

>> -----Original Message-----
>> From: Jose E. Marchesi <jose.marchesi@oracle.com>
>> Sent: Wednesday, July 26, 2023 2:26 AM
>> To: bpf@vger.kernel.org
>> Subject: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst
>> 
>> This patch fixes the documentation of the BPF_NEG instruction to denote
>> that it does not use the source register operand.
>> 
>> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
>> ---
>>  Documentation/bpf/standardization/instruction-set.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/bpf/standardization/instruction-set.rst
>> b/Documentation/bpf/standardization/instruction-set.rst
>> index 751e657973f0..6ef5534b410a 100644
>> --- a/Documentation/bpf/standardization/instruction-set.rst
>> +++ b/Documentation/bpf/standardization/instruction-set.rst
>> @@ -165,7 +165,7 @@ BPF_OR    0x40   dst \|= src
>>  BPF_AND   0x50   dst &= src
>>  BPF_LSH   0x60   dst <<= (src & mask)
>>  BPF_RSH   0x70   dst >>= (src & mask)
>> -BPF_NEG   0x80   dst = -src
>> +BPF_NEG   0x80   dst = -dst
>>  BPF_MOD   0x90   dst = (src != 0) ? (dst % src) : dst
>>  BPF_XOR   0xa0   dst ^= src
>>  BPF_MOV   0xb0   dst = src
>> --
>> 2.30.2
>
> Acked-by: Dave Thaler <dthaler@microsoft.com>
>
> Also, all changes to files in the standardization directory should also be cc'ed
> to bpf@ietf.org, which I am doing on this email.

Will do in future posts.  Thanks for CCing.

> Dave

-- 
Bpf mailing list
Bpf@ietf.org
https://www.ietf.org/mailman/listinfo/bpf

Re: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst

[Yonghong Song]

On 7/26/23 2:25 AM, Jose E. Marchesi wrote:
> This patch fixes the documentation of the BPF_NEG instruction to
> denote that it does not use the source register operand.
> 
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>

Acked-by: Yonghong Song <yonghong.song@linux.dev>

> ---
>   Documentation/bpf/standardization/instruction-set.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst
> index 751e657973f0..6ef5534b410a 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -165,7 +165,7 @@ BPF_OR    0x40   dst \|= src
>   BPF_AND   0x50   dst &= src
>   BPF_LSH   0x60   dst <<= (src & mask)
>   BPF_RSH   0x70   dst >>= (src & mask)
> -BPF_NEG   0x80   dst = -src
> +BPF_NEG   0x80   dst = -dst
>   BPF_MOD   0x90   dst = (src != 0) ? (dst % src) : dst
>   BPF_XOR   0xa0   dst ^= src
>   BPF_MOV   0xb0   dst = src

Re: [PATCH] bpf, docs: fix BPF_NEG entry in instruction-set.rst

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 26 Jul 2023 11:25:43 +0200 you wrote:
> This patch fixes the documentation of the BPF_NEG instruction to
> denote that it does not use the source register operand.
> 
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>
> ---
>  Documentation/bpf/standardization/instruction-set.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - bpf, docs: fix BPF_NEG entry in instruction-set.rst
    https://git.kernel.org/bpf/bpf-next/c/10d78a66a5f2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html