From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3381EC433F5 for ; Fri, 30 Sep 2022 00:53:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229506AbiI3Axa (ORCPT ); Thu, 29 Sep 2022 20:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiI3AxL (ORCPT ); Thu, 29 Sep 2022 20:53:11 -0400 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4F7D20589D; Thu, 29 Sep 2022 17:52:28 -0700 (PDT) Message-ID: <9d828483-21d0-18da-0870-babcb50d5c03@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1664499146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHJr4Xpyg9WKtImexYWG0vQTFzDQgaCHa5Ss8yShYZc=; b=BKi0gDIvZ4KSxHZQ+chheYRT/I4Rf1DJsoX2trucN8c/yhu1oEhhUIBOE2kf4StEQQ0U48 C7GjnGH5mXrkFkVxBgVQ9kC8adzkJhA5gZEi356riHWljcE1hI05rfYVK7pOfMiVAvYTMR fhLmlThZ7ULDgsRLHn4FHV11y9ggWaQ= Date: Thu, 29 Sep 2022 17:52:22 -0700 MIME-Version: 1.0 Subject: Re: [PATCH bpf-next] selftests/xsk: fix double free Content-Language: en-US To: Maciej Fijalkowski , Magnus Karlsson Cc: magnus.karlsson@intel.com, bjorn@kernel.org, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, jonathan.lemon@gmail.com, bpf@vger.kernel.org References: <20220929090133.7869-1-magnus.karlsson@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 9/29/22 3:44 AM, Maciej Fijalkowski wrote: > On Thu, Sep 29, 2022 at 11:01:33AM +0200, Magnus Karlsson wrote: >> From: Magnus Karlsson >> >> Fix a double free at exit of the test suite. >> >> Fixes: a693ff3ed561 ("selftests/xsk: Add support for executing tests on physical device") >> Signed-off-by: Magnus Karlsson >> --- >> tools/testing/selftests/bpf/xskxceiver.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c >> index ef33309bbe49..d1a5f3218c34 100644 >> --- a/tools/testing/selftests/bpf/xskxceiver.c >> +++ b/tools/testing/selftests/bpf/xskxceiver.c >> @@ -1953,9 +1953,6 @@ int main(int argc, char **argv) >> >> pkt_stream_delete(tx_pkt_stream_default); >> pkt_stream_delete(rx_pkt_stream_default); >> - free(ifobj_rx->umem); >> - if (!ifobj_tx->shared_umem) shared_umem means ifobj_rx->umem and ifobj_tx->umem are the same? No special handling is needed and ifobject_delete() will handle it? >> - free(ifobj_tx->umem); >> ifobject_delete(ifobj_tx); >> ifobject_delete(ifobj_rx); > > So basically we free this inside ifobject_delete().