From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
<netdev@vger.kernel.org>, <magnus.karlsson@intel.com>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <bpf@vger.kernel.org>,
<andrii@kernel.org>, <kpsingh@kernel.org>, <kafai@fb.com>,
<yhs@fb.com>, <songliubraving@fb.com>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Kiran Bhandare <kiranx.bhandare@intel.com>
Subject: Re: [PATCH net 2/2] ice: avoid XDP checks in ice_clean_tx_irq()
Date: Thu, 3 Mar 2022 10:25:13 -0800 [thread overview]
Message-ID: <9d9250be-0bdc-07c8-ee53-53041cd11b33@intel.com> (raw)
In-Reply-To: <20220303082848.64804e7a@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On 3/3/2022 8:28 AM, Jakub Kicinski wrote:
> On Thu, 3 Mar 2022 08:19:01 -0800 Jakub Kicinski wrote:
>> On Wed, 2 Mar 2022 09:59:28 -0800 Tony Nguyen wrote:
>>> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>>>
>>> Commit 9610bd988df9 ("ice: optimize XDP_TX workloads") introduced Tx IRQ
>>> cleaning routine dedicated for XDP rings. Currently it is impossible to
>>> call ice_clean_tx_irq() against XDP ring, so it is safe to drop
>>> ice_ring_is_xdp() calls in there.
>>>
>>> Fixes: 1c96c16858ba ("ice: update to newer kernel API")
>>> Fixes: cc14db11c8a4 ("ice: use prefetch methods")
>>> Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
>>> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>>> Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com> (A Contingent Worker at Intel)
>>> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
>> Is this really a fix?
> I'll apply patch 1 from the list, please reroute this one to net-next.
Thanks Jakub, will do.
-Tony
next prev parent reply other threads:[~2022-03-03 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 17:59 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-03-02 Tony Nguyen
2022-03-02 17:59 ` [PATCH net 1/2] ixgbe: xsk: change !netif_carrier_ok() handling in ixgbe_xmit_zc() Tony Nguyen
2022-03-02 17:59 ` [PATCH net 2/2] ice: avoid XDP checks in ice_clean_tx_irq() Tony Nguyen
2022-03-03 16:19 ` Jakub Kicinski
2022-03-03 16:28 ` Jakub Kicinski
2022-03-03 18:25 ` Tony Nguyen [this message]
2022-03-03 16:40 ` [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-03-02 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d9250be-0bdc-07c8-ee53-53041cd11b33@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kiranx.bhandare@intel.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox